Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate efistub offsets #48

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Calculate efistub offsets #48

merged 1 commit into from
Aug 2, 2023

Conversation

brandsimon
Copy link
Owner

systemd 254 changed the efistub, the hardcoded offsets are wrong with the new efistub.

See:
dracutdevs/dracut#2431
systemd/systemd@0fa2cac#commitcomment-76747223

systemd 254 changed the efistub, the hardcoded offsets are wrong with
the new efistub.

See:
dracutdevs/dracut#2431
systemd/systemd@0fa2cac#commitcomment-76747223
@brandsimon brandsimon merged commit ad1668e into main Aug 2, 2023
@brandsimon brandsimon deleted the sbr/fix_efistub branch August 2, 2023 18:37
@medhefgo
Copy link

medhefgo commented Aug 6, 2023

Why do people keep insisting to free-code this? You must align the section offsets to SectionAlignment.

@brandsimon
Copy link
Owner Author

brandsimon commented Aug 9, 2023

@medhefgo
Thank you very much for your hint. I will have a look and try to fix it.
I wanted to use systemd-ukify, but sadly Debian 12 does not have it in their repository. Do you know of any alternatives?

I hope it did not broke anything for you. I tested it with the old and the new systemd-stub.

@medhefgo
Copy link

medhefgo commented Aug 9, 2023

I wanted to use systemd-ukify, but sadly Debian 12 does not have it in their repository. Do you know of any alternatives?

ukify is v253+

@brandsimon
Copy link
Owner Author

brandsimon commented Aug 11, 2023

@medhefgo
Debian 12 is on 252. [0]
I tried to fix the alignment, can you please have a look if it is correct (besides the failing unittest on ubuntu)?
#51

[0] https://packages.debian.org/stable/main/systemd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants