Feature/nest validate pipeline supports directories and node versions #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vidriduch
approved these changes
May 23, 2024
| level: warning | ||
| workdir: ./src | ||
| level: ${{inputs.level}} | ||
| workdir: ${{ inputs.directory }}/src |
There was a problem hiding this comment.
Are we absolutely sure that all of our Nest projects have /src ? Isn't there a way how we can get/set this directory automatically rather then hardcoding it?
There was a problem hiding this comment.
true, moved to default value
… cover the typescript errors and eslint check
skifahrer
deleted the
feature/nest-validate-pipeline-supports-directories-and-node-versions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validation pipeline now has more options - choosing working directory, node version and warning levels.