Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes brave/brave-browser/5406 (WIP) #314

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Conversation

ryanbr
Copy link
Collaborator

@ryanbr ryanbr commented Jan 13, 2020

This a quick fix on an outstanding issue on brave/brave-browser#5406 for skepticalscience.com

Blocking this script will prevent the browser from a lock up. This solution is a temp fix, and could be re-tested/removed in future.

Was re-reported here: https://community.brave.com/t/why-does-this-website-lockup-the-browser/102074/2

@pes10k
Copy link
Collaborator

pes10k commented Jan 13, 2020

@ryanbr I appreciate the goal here, but I don't think we should merge this if the relevant script is tracking related, w/o at least a better solution planned out. Is this something we could solve with a uBO style replacement?

In ohther words, I'm happy to merge this, but only if @ryanbr you can take it on as an action item to make sure we get a better solution worked out here in the short term (even if its not on you to implement the better solution). WDYT?

@ryanbr
Copy link
Collaborator Author

ryanbr commented Jan 13, 2020

I'll investigate a better option, atleast we know which script is causing it now.

@ryanbr ryanbr changed the title fixes brave/brave-browser/5406 fixes brave/brave-browser/5406 (WIP) Jan 13, 2020
@pes10k pes10k merged commit cfe7f0a into brave:master Jan 13, 2020
@diracdeltas
Copy link
Member

alternatively we could just allow fingerprinting from skepticalscience.net on skepticalscience.com in https://github.com/brave/brave-core/blob/master/common/shield_exceptions.cc#L41. that might fix it given that the site works fine without fp turned on.

@ryanbr
Copy link
Collaborator Author

ryanbr commented Jan 14, 2020

The ubo method for reference: skepticalscience.net##+js(aopr, hcdrawticks) though a number of other snippets would do it. Not sure if its worth adding a whitelist for finderprinting.

@pes10k
Copy link
Collaborator

pes10k commented Jan 14, 2020

@ryanbr @diracdeltas sounds like we have a way forward then? Keep the just-added exception in place until cosmetic filtering lands and hits stable, and then pull it out?

If thats right, @ryanbr can you keep that on your todo list, to pull the just-added exception once cosmetic filtering hits stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants