Replace Prebake with Easylist Cookie #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this looks okay @AndriusA ? |
|
cc: @pes10k |
|
Looks good to me. Is the description still correct though for the new list? Does EasyList Cookie also "Remove obtrusive EU cookie law notices"? |
|
It does. Either blocking the specific cookie javascript or hiding via cosmetic filtering. |
|
Sounds good, just wasn't sure about the "EU" part |
|
Most 99% cookie mesages are EU related, but not exclusively (A few Russian, Australian and NZ sites) are covered. |
|
Okie dokie, then could you slightly change the description for the list too? Maybe just say something like "mostly targets EU etc" |
|
Probably easier to just remove the "EU" bit. so more of a generic "Removes obtrusive cookie law notices" |
AndriusA
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Prebake Cookie hasn't been updated since 2018, we should replace this with Easylist Cookie.
Should help with cookie notices and resolve brave/brave-browser#5318 Will be more affective when we roll out cosmetic filtering.
Rebase of #67 (just had some merge issues)
Also re-did
component_id:andbase64_public_key:PEM's also updated/uploaded.