-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Production Release 2024-05-02 #1180
Conversation
This isn't hooked up to any flows yet, and is only usable by admins, but lets us explore this functionality. https://github.com/brave/ads-ui/assets/51444/dd5c1544-3b67-400a-a832-8a31c0e8b4ab
Apparently if you don't do this you get junk displayed after deployment. Going forward we need to make this less error-prone. But for now just run `npm run extract`. Also fix a typo that I noticed while reviewing. <img width="952" alt="Screenshot 2024-05-01 at 17 30 51" src="https://github.com/brave/ads-ui/assets/51444/8bf1af8e-6ad1-4159-9ffe-5d4af45d7834">
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | Pending | |---|---|---|---|---|---|---|---|---| | [@fontsource/mulish](https://fontsource.org/fonts/mulish) ([source](https://github.com/fontsource/font-files/tree/HEAD/fonts/google/mulish)) | [`5.0.17` -> `5.0.18`](https://renovatebot.com/diffs/npm/@fontsource%2fmulish/5.0.17/5.0.18) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fontsource%2fmulish/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fontsource%2fmulish/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fontsource%2fmulish/5.0.17/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fontsource%2fmulish/5.0.17/5.0.18?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | | [@fontsource/poppins](https://fontsource.org/fonts/poppins) ([source](https://github.com/fontsource/font-files/tree/HEAD/fonts/google/poppins)) | [`5.0.13` -> `5.0.14`](https://renovatebot.com/diffs/npm/@fontsource%2fpoppins/5.0.13/5.0.14) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@fontsource%2fpoppins/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@fontsource%2fpoppins/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@fontsource%2fpoppins/5.0.13/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@fontsource%2fpoppins/5.0.13/5.0.14?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | | [@mui/x-data-grid](https://mui.com/x/react-data-grid/) ([source](https://github.com/mui/mui-x/tree/HEAD/packages/x-data-grid)) | [`7.3.0` -> `7.3.1`](https://renovatebot.com/diffs/npm/@mui%2fx-data-grid/7.3.0/7.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2fx-data-grid/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2fx-data-grid/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2fx-data-grid/7.3.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2fx-data-grid/7.3.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | | [@mui/x-date-pickers](https://mui.com/x/react-date-pickers/) ([source](https://github.com/mui/mui-x/tree/HEAD/packages/x-date-pickers)) | [`7.2.0` -> `7.3.1`](https://renovatebot.com/diffs/npm/@mui%2fx-date-pickers/7.2.0/7.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mui%2fx-date-pickers/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mui%2fx-date-pickers/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mui%2fx-date-pickers/7.2.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mui%2fx-date-pickers/7.2.0/7.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | | [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react)) | [`18.2.79` -> `18.3.1`](https://renovatebot.com/diffs/npm/@types%2freact/18.2.79/18.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact/18.2.79/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact/18.2.79/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | | [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/react-dom) ([source](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom)) | [`18.2.25` -> `18.3.0`](https://renovatebot.com/diffs/npm/@types%2freact-dom/18.2.25/18.3.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2freact-dom/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2freact-dom/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2freact-dom/18.2.25/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2freact-dom/18.2.25/18.3.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`7.7.0` -> `7.7.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/7.7.0/7.7.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2feslint-plugin/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2feslint-plugin/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | `7.8.0` | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`7.7.0` -> `7.7.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/7.7.0/7.7.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2fparser/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2fparser/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/7.7.0/7.7.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | `7.8.0` | | [actions/checkout](https://github.com/actions/checkout) | `v4.1.3` -> `v4.1.4` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/actions%2fcheckout/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/actions%2fcheckout/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/actions%2fcheckout/v4.1.3/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/actions%2fcheckout/v4.1.3/v4.1.4?slim=true)](https://docs.renovatebot.com/merge-confidence/) | action | patch | | | [formik](https://formik.org) ([source](https://github.com/jaredpalmer/formik)) | [`2.4.5` -> `2.4.6`](https://renovatebot.com/diffs/npm/formik/2.4.5/2.4.6) | [![age](https://developer.mend.io/api/mc/badges/age/npm/formik/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/formik/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/formik/2.4.5/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/formik/2.4.5/2.4.6?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | patch | | | [github/codeql-action](https://github.com/github/codeql-action) | `v3.25.1` -> `v3.25.3` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/github%2fcodeql-action/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/github%2fcodeql-action/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/github%2fcodeql-action/v3.25.1/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/github%2fcodeql-action/v3.25.1/v3.25.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | action | patch | | | [react](https://reactjs.org/) ([source](https://github.com/facebook/react/tree/HEAD/packages/react)) | [`18.2.0` -> `18.3.1`](https://renovatebot.com/diffs/npm/react/18.2.0/18.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | | [react-dom](https://reactjs.org/) ([source](https://github.com/facebook/react/tree/HEAD/packages/react-dom)) | [`18.2.0` -> `18.3.1`](https://renovatebot.com/diffs/npm/react-dom/18.2.0/18.3.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/react-dom/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/react-dom/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/react-dom/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/react-dom/18.2.0/18.3.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | dependencies | minor | | | [vitest](https://github.com/vitest-dev/vitest) ([source](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest)) | [`1.5.0` -> `1.5.2`](https://renovatebot.com/diffs/npm/vitest/1.5.0/1.5.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/vitest/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vitest/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vitest/1.5.0/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vitest/1.5.0/1.5.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | `1.5.3` | --- ### Release Notes <details> <summary>fontsource/font-files (@​fontsource/mulish)</summary> ### [`v5.0.18`](https://github.com/fontsource/font-files/compare/643d5496631adb16c66ab3fc2f9e128d01817307...f069547c3d25cb9602fdbc1d9eb1f34046dc8353) [Compare Source](https://github.com/fontsource/font-files/compare/643d5496631adb16c66ab3fc2f9e128d01817307...f069547c3d25cb9602fdbc1d9eb1f34046dc8353) </details> <details> <summary>fontsource/font-files (@​fontsource/poppins)</summary> ### [`v5.0.14`](https://github.com/fontsource/font-files/compare/fd9fe9317a4ab7042845961a60b1cace22dc14d6...f069547c3d25cb9602fdbc1d9eb1f34046dc8353) [Compare Source](https://github.com/fontsource/font-files/compare/fd9fe9317a4ab7042845961a60b1cace22dc14d6...f069547c3d25cb9602fdbc1d9eb1f34046dc8353) </details> <details> <summary>mui/mui-x (@​mui/x-data-grid)</summary> ### [`v7.3.1`](https://github.com/mui/mui-x/blob/HEAD/CHANGELOG.md#731) [Compare Source](https://github.com/mui/mui-x/compare/v7.3.0...v7.3.1) *Apr 26, 2024* We'd like to offer a big thanks to the 13 contributors who made this release possible. Here are some highlights ✨: - 🎁 Scatter Charts get a [z-axis to allow coloring data points independently from their coordinates](https://mui.com/x/react-charts/scatter/#color-scale) - 🌍 Improve Catalan (ca-ES) and Spanish (es-ES) locales on the Date and Time Pickers - 🐞 Bugfixes - 📚 Documentation improvements ##### Data Grid ##### `@mui/x-data-grid@7.3.1` - \[DataGrid] Fix date filtering for negative timezone offsets ([#​12836](https://github.com/mui/mui-x/issues/12836)) [@​cherniavskii](https://github.com/cherniavskii) - \[DataGrid] Fix flex column width when used with pinned columns ([#​12849](https://github.com/mui/mui-x/issues/12849)) [@​romgrk](https://github.com/romgrk) - \[DataGrid] Fix group header resize ([#​12863](https://github.com/mui/mui-x/issues/12863)) [@​arminmeh](https://github.com/arminmeh) - \[DataGrid] Pass slot props to `columnHeaders` slot ([#​12768](https://github.com/mui/mui-x/issues/12768)) [@​cherniavskii](https://github.com/cherniavskii) ##### `@mui/x-data-grid-pro@7.3.1` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-data-grid@7.3.1`. ##### `@mui/x-data-grid-premium@7.3.1` [![premium](https://mui.com/r/x-premium-svg)](https://mui.com/r/x-premium-svg-link "Premium plan") Same changes as in `@mui/x-data-grid-pro@7.3.1`. ##### Date and Time Pickers ##### `@mui/x-date-pickers@7.3.1` - \[l10n] Improve Catalan (ca-ES) locale ([#​12856](https://github.com/mui/mui-x/issues/12856)) [@​soler1212](https://github.com/soler1212) - \[l10n] Improve Spanish (es-ES) locale ([#​12858](https://github.com/mui/mui-x/issues/12858)) [@​soler1212](https://github.com/soler1212) ##### `@mui/x-date-pickers-pro@7.3.1` [![pro](https://mui.com/r/x-pro-svg)](https://mui.com/r/x-pro-svg-link "Pro plan") Same changes as in `@mui/x-date-pickers@7.3.1`. ##### Charts ##### `@mui/x-charts@7.3.1` - \[charts] Add documentation on border radius alternative for `BarCharts` ([#​12859](https://github.com/mui/mui-x/issues/12859)) [@​JCQuintas](https://github.com/JCQuintas) - \[charts] Add z-axis to colorize scatter charts ([#​12738](https://github.com/mui/mui-x/issues/12738)) [@​alexfauquette](https://github.com/alexfauquette) - \[charts] Fix left/bottomAxis not picking up default axis id ([#​12894](https://github.com/mui/mui-x/issues/12894)) [@​JCQuintas](https://github.com/JCQuintas) - \[charts] Improve default tooltip content ([#​12257](https://github.com/mui/mui-x/issues/12257)) [@​oliviertassinari](https://github.com/oliviertassinari) - \[charts] Round y values for bar chart ([#​12846](https://github.com/mui/mui-x/issues/12846)) [@​alexfauquette](https://github.com/alexfauquette) ##### Tree View ##### `@mui/x-tree-view@7.3.1` - \[TreeView] Remove un-needed `aria-activedescendant` attribute ([#​12867](https://github.com/mui/mui-x/issues/12867)) [@​flaviendelangle](https://github.com/flaviendelangle) - \[TreeView] Rework the selection internals ([#​12703](https://github.com/mui/mui-x/issues/12703)) [@​flaviendelangle](https://github.com/flaviendelangle) - \[TreeView] Use the order in which the items are displayed for `type-ahead` ([#​12827](https://github.com/mui/mui-x/issues/12827)) [@​flaviendelangle](https://github.com/flaviendelangle) ##### Docs - \[docs] Add demo for styling charts with `sx` props ([#​12791](https://github.com/mui/mui-x/issues/12791)) [@​derek-0000](https://github.com/derek-0000) - \[docs] Cover webpack 4 support in migration guide ([#​12710](https://github.com/mui/mui-x/issues/12710)) [@​cherniavskii](https://github.com/cherniavskii) - \[docs] Document interfaces for charts ([#​12656](https://github.com/mui/mui-x/issues/12656)) [@​alexfauquette](https://github.com/alexfauquette) - \[docs] Fix Vale regression ([#​12862](https://github.com/mui/mui-x/issues/12862)) [@​oliviertassinari](https://github.com/oliviertassinari) - \[docs] Improve Data Grid migration guide ([#​12879](https://github.com/mui/mui-x/issues/12879)) [@​MBilalShafi](https://github.com/MBilalShafi) - \[docs] Update Column features availability ([#​12865](https://github.com/mui/mui-x/issues/12865)) [@​DanailH](https://github.com/DanailH) ##### Core - \[core] Fix `l10n` GH workflow ([#​12895](https://github.com/mui/mui-x/issues/12895)) [@​LukasTy](https://github.com/LukasTy) - \[core] Match Base UI and Toolpad [@​oliviertassinari](https://github.com/oliviertassinari) - \[core] Remove redundant `setupFiles` entries in `package.json` ([#​12899](https://github.com/mui/mui-x/issues/12899)) [@​LukasTy](https://github.com/LukasTy) - \[core] Use `describeTreeView` for focus tests ([#​12698](https://github.com/mui/mui-x/issues/12698)) [@​flaviendelangle](https://github.com/flaviendelangle) - \[core] Use `describeTreeView` for type-ahead tests ([#​12811](https://github.com/mui/mui-x/issues/12811)) [@​flaviendelangle](https://github.com/flaviendelangle) - \[code-infra] Change package manager to `pnpm` ([#​11875](https://github.com/mui/mui-x/issues/11875)) [@​LukasTy](https://github.com/LukasTy) - \[code-infra] Closer sync with eslint config of codebase ([#​12864](https://github.com/mui/mui-x/issues/12864)) [@​oliviertassinari](https://github.com/oliviertassinari) - \[support-infra] Add release announcement to GitHub workflows ([#​11867](https://github.com/mui/mui-x/issues/11867)) ([#​12843](https://github.com/mui/mui-x/issues/12843)) [@​michelengelen](https://github.com/michelengelen) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v7.7.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#771-2024-04-22) [Compare Source](https://github.com/typescript-eslint/typescript-eslint/compare/v7.7.0...v7.7.1) ##### 🩹 Fixes - **eslint-plugin:** \[no-unsafe-assignment] handle shorthand property assignment - **eslint-plugin:** \[explicit-function-return-type] fix checking wrong ancestor's return type - **eslint-plugin:** \[prefer-optional-chain] only look at left operand for `requireNullish` - **eslint-plugin:** \[no-for-in-array] refine report location - **eslint-plugin:** \[no-unnecessary-type-assertion] allow non-null assertion for void type ##### ❤️ Thank You - Abraham Guo - Kirk Waiblinger - YeonJuan You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v7.7.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#771-2024-04-22) [Compare Source](https://github.com/typescript-eslint/typescript-eslint/compare/v7.7.0...v7.7.1) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v4.1.4`](https://github.com/actions/checkout/blob/HEAD/CHANGELOG.md#v414) [Compare Source](https://github.com/actions/checkout/compare/v4.1.3...v4.1.4) - Disable `extensions.worktreeConfig` when disabling `sparse-checkout` by [@​jww3](https://github.com/jww3) in [actions/checkout#1692 - Add dependabot config by [@​cory-miller](https://github.com/cory-miller) in [actions/checkout#1688 - Bump the minor-actions-dependencies group with 2 updates by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1693 - Bump word-wrap from 1.2.3 to 1.2.5 by [@​dependabot](https://github.com/dependabot) in [actions/checkout#1643 </details> <details> <summary>jaredpalmer/formik (formik)</summary> ### [`v2.4.6`](https://github.com/jaredpalmer/formik/compare/formik@2.4.5...c798145e2307b0273ea4d9c6bfd8250f28d95be9) [Compare Source](https://github.com/jaredpalmer/formik/compare/formik@2.4.5...formik@2.4.6) </details> <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.25.3`](https://github.com/github/codeql-action/compare/v3.25.2...v3.25.3) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.2...v3.25.3) ### [`v3.25.2`](https://github.com/github/codeql-action/compare/v3.25.1...v3.25.2) [Compare Source](https://github.com/github/codeql-action/compare/v3.25.1...v3.25.2) </details> <details> <summary>facebook/react (react)</summary> ### [`v18.3.1`](https://github.com/facebook/react/compare/a87edf62d7d69705ddbcec9a24f0780b3db7535f...a87edf62d7d69705ddbcec9a24f0780b3db7535f) [Compare Source](https://github.com/facebook/react/compare/v18.3.0...v18.3.1) ### [`v18.3.0`](https://github.com/facebook/react/compare/v18.2.0...a87edf62d7d69705ddbcec9a24f0780b3db7535f) [Compare Source](https://github.com/facebook/react/compare/v18.2.0...v18.3.0) </details> <details> <summary>facebook/react (react-dom)</summary> ### [`v18.3.1`](https://github.com/facebook/react/compare/a87edf62d7d69705ddbcec9a24f0780b3db7535f...a87edf62d7d69705ddbcec9a24f0780b3db7535f) [Compare Source](https://github.com/facebook/react/compare/v18.3.0...v18.3.1) ### [`v18.3.0`](https://github.com/facebook/react/compare/v18.2.0...a87edf62d7d69705ddbcec9a24f0780b3db7535f) [Compare Source](https://github.com/facebook/react/compare/v18.2.0...v18.3.0) </details> <details> <summary>vitest-dev/vitest (vitest)</summary> ### [`v1.5.2`](https://github.com/vitest-dev/vitest/releases/tag/v1.5.2) [Compare Source](https://github.com/vitest-dev/vitest/compare/v1.5.1...v1.5.2) ##### 🐞 Bug Fixes - Check for null before storing in weakmap - by [@​sheremet-va](https://github.com/sheremet-va) [<samp>(ce368)</samp>](https://github.com/vitest-dev/vitest/commit/ce368457) ##### [View changes on GitHub](https://github.com/vitest-dev/vitest/compare/v1.5.1...v1.5.2) ### [`v1.5.1`](https://github.com/vitest-dev/vitest/releases/tag/v1.5.1) [Compare Source](https://github.com/vitest-dev/vitest/compare/v1.5.0...v1.5.1) ##### 🚀 Features - **api**: `startVitest()` to accept `stdout` and `stdin` - by [@​AriPerkkio](https://github.com/AriPerkkio) in [vitest-dev/vitest#5493 [<samp>(780b1)</samp>](https://github.com/vitest-dev/vitest/commit/780b187f) - This is listed as a feature, but it doesn't increase the minor version because `startVitest` API is experimental and doesn't follow semver. ##### 🐞 Bug Fixes - Close vite servers on all resolved projects - by [@​surc54](https://github.com/surc54) in [vitest-dev/vitest#5544 [<samp>(413ec)</samp>](https://github.com/vitest-dev/vitest/commit/413ec5e6) - Fix default `import.meta.env.PROD: false` - by [@​hi-ogawa](https://github.com/hi-ogawa) in [vitest-dev/vitest#5561 [<samp>(9c649)</samp>](https://github.com/vitest-dev/vitest/commit/9c64967f) - Resolve cwd correctly when initiating projects - by [@​sheremet-va](https://github.com/sheremet-va) in [vitest-dev/vitest#5582 [<samp>(ec9d7)</samp>](https://github.com/vitest-dev/vitest/commit/ec9d7c93) - Always run `onTestFinished` in reverse order - by [@​sheremet-va](https://github.com/sheremet-va) in [vitest-dev/vitest#5598 [<samp>(23f29)</samp>](https://github.com/vitest-dev/vitest/commit/23f29cea) - **browser**: - Disable `fileParallelism` by default on browser pool - by [@​hi-ogawa](https://github.com/hi-ogawa) in [vitest-dev/vitest#5528 [<samp>(5c69f)</samp>](https://github.com/vitest-dev/vitest/commit/5c69f3f5) - Dispose tester iframe on done - by [@​hi-ogawa](https://github.com/hi-ogawa) in [vitest-dev/vitest#5595 [<samp>(b2135)</samp>](https://github.com/vitest-dev/vitest/commit/b2135710) - **coverage**: - Fix bundling of `v8-to-istanbul` - by [@​AriPerkkio](https://github.com/AriPerkkio) in [vitest-dev/vitest#5549 [<samp>(df6a4)</samp>](https://github.com/vitest-dev/vitest/commit/df6a4328) - Prevent crash when `cleanOnRerun` is disabled - by [@​AriPerkkio](https://github.com/AriPerkkio) in [vitest-dev/vitest#5540 [<samp>(ea3c1)</samp>](https://github.com/vitest-dev/vitest/commit/ea3c16e4) - `thresholds` to compare files relative to root - by [@​AriPerkkio](https://github.com/AriPerkkio) in [vitest-dev/vitest#5574 [<samp>(80265)</samp>](https://github.com/vitest-dev/vitest/commit/80265b40) - **expect**: - Fix `toEqual` and `toMatchObject` with circular references - by [@​hi-ogawa](https://github.com/hi-ogawa) in [vitest-dev/vitest#5535 [<samp>(9e641)</samp>](https://github.com/vitest-dev/vitest/commit/9e6417c9) - **vitest**: - Fix false positive file filter match with leading slash - by [@​hi-ogawa](https://github.com/hi-ogawa) in [vitest-dev/vitest#5578 [<samp>(316eb)</samp>](https://github.com/vitest-dev/vitest/commit/316eb739) - Watch the output directory correctly - by [@​sheremet-va](https://github.com/sheremet-va) in [vitest-dev/vitest#5584 [<samp>(e40f9)</samp>](https://github.com/vitest-dev/vitest/commit/e40f9924) - StubEnv casts boolean on PROD/SSR/DEV - by [@​sheremet-va](https://github.com/sheremet-va) in [vitest-dev/vitest#5590 [<samp>(4da88)</samp>](https://github.com/vitest-dev/vitest/commit/4da88045) ##### [View changes on GitHub](https://github.com/vitest-dev/vitest/compare/v1.5.0...v1.5.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* 0-4 * * 3" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/brave/ads-ui). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Relies on brave/ads-serve#3884 <img width="774" alt="Screenshot 2024-05-02 at 12 46 38" src="https://github.com/brave/ads-ui/assets/51444/84e1a83b-3eab-4198-9b82-ff1c2b43a5fd">
[puLL-Merge] - brave/ads-ui@1180 Here is my review of the PR: DescriptionThis PR adds a new search campaign creation flow, allowing advertisers to select and customize search ads for a given domain and country. The flow consists of selecting landing pages/creatives, finalizing campaign details, and generating a JSON file with the configuration to submit to Brave. ChangesChanges
Security Hotspots
Let me know if you have any other questions! Overall the code looks well structured and follows existing patterns in the codebase. The main areas to double check are around validation, access control and data security for the new search prospects functionality. |
Features
Fixes
Chores