Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update logo for product consistency #1211

Merged
merged 4 commits into from
May 31, 2024
Merged

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented May 30, 2024

Want to change the logo for more consistency


Screenshare.-.2024-05-31.11_54_30.AM.mp4

@IanKrieger IanKrieger requested a review from a team as a code owner May 30, 2024 17:43
@lukaslevert
Copy link
Collaborator

Logo, headers, and hamburger menu look great @IanKrieger.

What about if we changed "Ad inquires" to "Contact sales" so that it's clear that it's not just general inquiries, but a way of contacting the sales team?

What I'd like to try to avoid is people contacting that email with support queries for self-service, since those should be going to the ad ops email, not the sales outreach.

Copy link

[puLL-Merge] - brave/ads-ui@1211

Description

This PR makes several changes to the landing page UI, including:

  • Adding new Brave logo SVG images
  • Updating the app bar with links to various pages like "Brave Search Ads", "Basic Attention Token", and "Contact sales"
  • Extracting a reusable PageLink component for the app bar links
  • Some style and layout tweaks

The motivation seems to be to improve the landing page navigation and branding.

Changes

Changes

src/assets/images/full-brave-brand-black.svg and src/assets/images/full-brave-brand.svg

  • Added new SVG versions of the Brave logo

src/components/AppBar/LandingPageAppBar.tsx

  • Imported the new Brave logo SVGs and use them conditionally based on page
  • Added several new PageLink components to the app bar for pages like "Brave Search Ads", "Basic Attention Token" etc
  • Moved "Get started" link into a PageLink
  • Added the page links to the mobile menu
  • Some other minor refactoring and cleanup

src/components/AppBar/PageLink.tsx

  • Added new reusable PageLink component that renders a link with translated text
  • Takes to prop for URL, msg prop for i18n message, and textColor
  • Handles mobile styling

src/locales/en.po, src/locales/es.po, src/locales/pt.po, src/locales/test.po

  • Localization file updates

src/search/SearchLandingPage.tsx

  • Minor padding tweak to image carousel on small screens

Security Hotspots

  • The SVG logos are loaded from the same origin so there are no obvious vulnerabilities from those additions.
  • The to prop of PageLink that sets the link URL comes from constants within the same component, so is not vulnerable to injection.

Let me know if you have any other questions!

@IanKrieger IanKrieger merged commit fcc7971 into master May 31, 2024
8 checks passed
@IanKrieger IanKrieger deleted the feat/update-logo branch May 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants