-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crio.do does not work on Brave #10367
Comments
The issue here is that the site tries to do auth through 3p cookies on https://crio-prod.firebaseapp.com/__/auth/iframe Some options:
Adding to agenda for privacy confab on Tuesday |
Related to this? #9852 |
@ryanbr yea, i expect so. The way firebase does their own, 3p iframe version of SSO is… bad… |
@ryanbr can you add a 3p cookie exception for *.firebaseapp.com in brave-core then? That'll allow us to at least close these two issues, until we have a better option. Feel free to tag me for review |
Since I had a existing fix for sony.com, I adjusted that PR to include firebase: |
Just a couple of suggestions:
|
For 1 at least, i think that'd be an odd mismatch though, since the first hop of the data is to firebase and not google For 2, do you know if folks are sorting this out correclty upstream? |
closed with brave/brave-core#5952 |
Hey, I hope this issue gets patched in coming releases, as I suppose firebase and brave have not got along well from a long time now. Best, |
@icy-meteor , yep! Its currently fixed in nightly and will make its way to stable in the 1.12 release (the 1.11 release comes out next Wednesday, so it'll be in beta starting July 14, 2020, and in stable August 4, 2020). The way the fix will work is that if a user has "enable gmail auth" enabled in shields (the default setting) then that'll also enable cookies against firebase. So, in the default configuration, folks will be able to log into your site w/o any changes. Relevant fix is here: brave/brave-core#5952 Hope that helps! |
Thanks for the update, @pes10k! |
Verification passed on
|
User reported that crio.do (a Firebase website ) does not let them authenticate using a G-Auth.
Chrome done.
Seems like a ton of 3P cookies all over the place via Firebase.
cc @pes10k - please move it to the appropriate repo/project.
The text was updated successfully, but these errors were encountered: