Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crio.do does not work on Brave #10367

Closed
mandar-brave opened this issue Jun 19, 2020 · 12 comments
Closed

Crio.do does not work on Brave #10367

mandar-brave opened this issue Jun 19, 2020 · 12 comments
Labels
feature/shields/cookies Cookie controls implemented as part of Shields. OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Win64 QA/Yes release-notes/include workaround/allow-all-cookies

Comments

@mandar-brave
Copy link

User reported that crio.do (a Firebase website ) does not let them authenticate using a G-Auth.
Chrome done.

Seems like a ton of 3P cookies all over the place via Firebase.

cc @pes10k - please move it to the appropriate repo/project.

@pes10k
Copy link
Contributor

pes10k commented Jun 22, 2020

The issue here is that the site tries to do auth through 3p cookies on https://crio-prod.firebaseapp.com/__/auth/iframe

Some options:

  • add 3p cookie exception for firebaseapp.com
  • storage access API for 3p storage
  • dual key storage

Adding to agenda for privacy confab on Tuesday

@ryanbr
Copy link

ryanbr commented Jun 23, 2020

Related to this? #9852

@pes10k
Copy link
Contributor

pes10k commented Jun 23, 2020

@ryanbr yea, i expect so. The way firebase does their own, 3p iframe version of SSO is… bad…

@pes10k
Copy link
Contributor

pes10k commented Jun 23, 2020

@ryanbr can you add a 3p cookie exception for *.firebaseapp.com in brave-core then? That'll allow us to at least close these two issues, until we have a better option. Feel free to tag me for review

@pes10k pes10k added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 23, 2020
@ryanbr
Copy link

ryanbr commented Jun 23, 2020

Since I had a existing fix for sony.com, I adjusted that PR to include firebase:

brave/brave-core#5857

@jumde
Copy link
Contributor

jumde commented Jun 23, 2020

Just a couple of suggestions:

  1. Gate this behind a Google Login toggle in brave://settings/socialBlocking
  2. There is an issue in chromium, cookies are not deleted if an exception is added if all-browser history is cleared. There are couple of issues for accounts.google.com exception.

@pes10k
Copy link
Contributor

pes10k commented Jun 23, 2020

For 1 at least, i think that'd be an odd mismatch though, since the first hop of the data is to firebase and not google

For 2, do you know if folks are sorting this out correclty upstream?

@pes10k
Copy link
Contributor

pes10k commented Jun 26, 2020

closed with brave/brave-core#5952

@rahulsuresh-git
Copy link

Hey,
This is Rahul from Crio.Do. Thanks for bringing this up!
We have been facing this issue from Day 1. Again, as @pes10k said, #9852 was a known issue and we urge users to allow "All cookies" while using our platform but it is not the kind of experience we are trying to provide.

I hope this issue gets patched in coming releases, as I suppose firebase and brave have not got along well from a long time now.

Best,
Rahul

@pes10k
Copy link
Contributor

pes10k commented Jul 10, 2020

@icy-meteor , yep! Its currently fixed in nightly and will make its way to stable in the 1.12 release (the 1.11 release comes out next Wednesday, so it'll be in beta starting July 14, 2020, and in stable August 4, 2020).

The way the fix will work is that if a user has "enable gmail auth" enabled in shields (the default setting) then that'll also enable cookies against firebase. So, in the default configuration, folks will be able to log into your site w/o any changes.

Relevant fix is here: brave/brave-core#5952

Hope that helps!

@rahulsuresh-git
Copy link

Thanks for the update, @pes10k!

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 28, 2020

Verification passed on


Brave | 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


  • Verified the issue description,
  • Ensured that user can log in to crio.do using G- auth with default shield settings
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/cookies Cookie controls implemented as part of Shields. OS/Desktop OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. privacy QA Pass-Win64 QA/Yes release-notes/include workaround/allow-all-cookies
Projects
None yet
Development

No branches or pull requests

6 participants