Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Gmail image signatures are not loading #10478

Closed
ryanbr opened this issue Jun 25, 2020 · 1 comment · Fixed by brave/brave-core#5953
Closed

[Desktop] Gmail image signatures are not loading #10478

ryanbr opened this issue Jun 25, 2020 · 1 comment · Fixed by brave/brave-core#5953

Comments

@ryanbr
Copy link

ryanbr commented Jun 25, 2020

Description

Signatures images not showing in Gmail

Steps to Reproduce

  1. Open Gmail
  2. Open settings
  3. Scroll down to Signature
  4. Create new signature, give it a new name
  5. Click on Insert Image
  6. Click Upload, Find any image on your PC

Actual result:

signature-broken

Expected result:

signature-broken2

Reproduces how often:

Easily, with Shields enabled/default.

Brave version (brave://version info)

Version 1.10.97 Chromium: 83.0.4103.116 (Official Build) (64-bit)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? Yes (allow all cookies)
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

As a temp option, Allow all cookies fixes this. Tested referrer issues, not affecting it.

Cookie issues from googleusercontent.com, we should allow cookies on google.com domain.
google-cookies

ryanbr added a commit to ryanbr/brave-core that referenced this issue Jun 25, 2020
ryanbr added a commit to ryanbr/brave-core that referenced this issue Jun 25, 2020
Fix missing bracket
ryanbr added a commit to ryanbr/brave-core that referenced this issue Jun 25, 2020
@bsclifton bsclifton added this to the 1.12.x - Nightly milestone Jun 29, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 21, 2020

Verified passed with

Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Reproduced issue using 1.11.97:

11197 - reproduce

  • Upgraded to 1.12.x and confirmed issue resolved:

11294 - upgrade

  • Verified STR from description using a clean profile:

11294 - clean


Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


  • Reproduced issue using 1.11.97:
    image

  • Upgraded to 1.12.x and confirmed issue resolved:
    image

  • Verified STR from description using a clean profile:
    image

Verification passed on

Brave 1.12.104 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
  • Verified STR from description
    image

@rebron rebron changed the title [Desktop] Gmail image signatures not loading [Desktop] Gmail image signatures are not loading Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment