State level ads being shown on version without state level targeting

[LaurenWags]

Description

On a version without state-level targeting (such as 1.11.87), I would expect that I would not be served ads which are targeted to a specific state, however I am being served these ads.

Steps to Reproduce

Pre-req - use Charles Proxy and this catalog - USstates.txt

1. Clean profile, use staging env/flags.
2. Enable Rewards.
3. Trigger an ad notification.

Actual result:

Get an ad targeted for a US state

[20948:775:0703/103714.053067:VERBOSE1:ads_impl.cc(825)] No categories to serve targeted ads
[20948:775:0703/103714.053145:VERBOSE1:ads_impl.cc(896)] Serving ad notification from untargeted category
[20948:775:0703/103714.054499:VERBOSE2:ads_impl.cc(992)] 2 eligible ads with a priority of 1
[20948:775:0703/103714.054581:VERBOSE1:ads_impl.cc(944)] Found 2 eligible ads
[20948:775:0703/103714.054621:VERBOSE3:client.cc(580)] Saving client state
[20948:775:0703/103714.054678:VERBOSE3:client.cc(580)] Saving client state
[20948:775:0703/103714.054732:VERBOSE3:client.cc(580)] Saving client state
[20948:775:0703/103714.054798:VERBOSE3:client.cc(580)] Saving client state
[20948:775:0703/103714.054849:VERBOSE1:ads_impl.cc(1260)] Ad notification shown:
  uuid: 5c92d364-28e2-4874-85ca-d190ff73750a
  parentUuid: f437339b-de0e-4393-953e-1617bab27006
  creativeInstanceId: 89112634-8567-4dcb-9432-f81153c07ea6
  creativeSetId: afe51106-2c27-4aeb-87a6-cbf836f6da0b
  category: untargeted
  title: This is State Level Targeted to Oregon
  body: But still completely private!
  targetUrl: https://www.brave.com

Expected result:

I should not get any state level ads since my version of Brave does not support them

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.11.87 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
Revision	8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release? unsure
• Can you reproduce this issue with the beta channel? yes, 1.11.x
• Can you reproduce this issue with the dev channel? yes, 1.11.x
• Can you reproduce this issue with the nightly channel? nightly (1.12.x) has state level targeting

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @jsecretan @tmancey @brave/legacy_qa

[LaurenWags]

QA/Blocked pending confirmation of which version of the catalog does contain state level targeting

[LaurenWags]

Verified passed with

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Confirmed version 1.11.104 (current release version) gets v2 of the catalog on staging and production:

• Staging:

[10579:775:0804/163307.104739:VERBOSE1:ads_serve.cc(41)] Download catalog
[10579:775:0804/163307.104797:VERBOSE2:ads_serve.cc(42)] GET /v2/catalog
[10579:775:0804/163307.105173:VERBOSE5:ads_serve.cc(47)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/catalog
  Method: GET

• Production:

[10631:775:0804/163535.259451:VERBOSE1:ads_serve.cc(41)] Download catalog
[10631:775:0804/163535.259511:VERBOSE2:ads_serve.cc(42)] GET /v2/catalog
[10631:775:0804/163535.259550:VERBOSE5:ads_serve.cc(47)] URL Request:
  URL: https://ads-serve.brave.com/v2/catalog
  Method: GET

Confirmed version 1.12.105 gets v3 of the catalog on staging and production:

• Staging:

[10686:775:0804/163713.383380:VERBOSE1:ads_serve.cc(38)] Download catalog
[10686:775:0804/163713.383450:VERBOSE2:ads_serve.cc(39)] GET /v3/catalog
[10686:775:0804/163713.383484:VERBOSE5:ads_serve.cc(44)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v3/catalog
  Method: GET

• Production:

[10766:775:0804/163817.670554:VERBOSE1:ads_serve.cc(38)] Download catalog
[10766:775:0804/163817.670613:VERBOSE2:ads_serve.cc(39)] GET /v3/catalog
[10766:775:0804/163817.670652:VERBOSE5:ads_serve.cc(44)] URL Request:
  URL: https://ads-serve.brave.com/v3/catalog
  Method: GET

• Confirmed Staging catalog v2 does not contain any state-level ads
• Confirmed Staging catalog v3 does contain state-level ads

---

Verification passed on

Brave | 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

• Confirmed version 1.12.105 gets v3 of the catalog on staging and production:

Staging 1.12.105

[21728:19732:0805/130851.424:VERBOSE1:ads_serve.cc(38)] Download catalog
[21728:19732:0805/130851.424:VERBOSE2:ads_serve.cc(39)] GET /v3/catalog
[21728:19732:0805/130851.425:VERBOSE5:ads_serve.cc(44)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v3/catalog
  Method: GET

Production 1.12.105

[11452:24224:0805/131437.272:VERBOSE1:ads_serve.cc(38)] Download catalog
[11452:24224:0805/131437.272:VERBOSE2:ads_serve.cc(39)] GET /v3/catalog
[11452:24224:0805/131437.272:VERBOSE5:ads_serve.cc(44)] URL Request:
  URL: https://ads-serve.brave.com/v3/catalog
  Method: GET

• Confirmed version 1.11.104 (current release version) gets v2 of the catalog on staging and production:

Staging 1.11.104

[22832:18908:0805/131807.390:VERBOSE1:ads_serve.cc(41)] Download catalog
[22832:18908:0805/131807.390:VERBOSE2:ads_serve.cc(42)] GET /v2/catalog
[22832:18908:0805/131807.390:VERBOSE5:ads_serve.cc(47)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/catalog
  Method: GET

Production 1.11.104

[8880:19364:0805/132129.990:VERBOSE1:ads_serve.cc(41)] Download catalog
[8880:19364:0805/132129.990:VERBOSE2:ads_serve.cc(42)] GET /v2/catalog
[8880:19364:0805/132129.990:VERBOSE5:ads_serve.cc(47)] URL Request:
  URL: https://ads-serve.brave.com/v2/catalog
  Method: GET

---

Verification passed on

Brave	1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision	a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS	Ubuntu 18.04 LTS

Confirmed version 1.11.104 (current release version) gets v2 of the catalog on staging and production:

• Staging:

[5271:5271:0810/144450.795380:VERBOSE1:ads_serve.cc(41)] Download catalog
[5271:5271:0810/144450.795539:VERBOSE2:ads_serve.cc(42)] GET /v2/catalog
[5271:5271:0810/144450.795606:VERBOSE5:ads_serve.cc(47)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v2/catalog
  Method: GET

• Production:
  [4846:4846:0810/144314.889108:VERBOSE1:ads_serve.cc(41)] Download catalog
  [4846:4846:0810/144314.889798:VERBOSE2:ads_serve.cc(42)] GET /v2/catalog
  [4846:4846:0810/144314.890426:VERBOSE5:ads_serve.cc(47)] URL Request:
  URL: https://ads-serve.brave.com/v2/catalog
  Method: GET

Confirmed version 1.12.105 gets v3 of the catalog on staging and production:
 * Staging:

[3419:3419:0810/143837.294416:VERBOSE1:ads_serve.cc(38)] Download catalog
[3419:3419:0810/143837.294556:VERBOSE2:ads_serve.cc(39)] GET /v3/catalog
[3419:3419:0810/143837.296310:VERBOSE5:ads_serve.cc(44)] URL Request:
URL: https://ads-serve.bravesoftware.com/v3/catalog
Method: GET

 * Production:

[3831:3831:0810/144009.671849:VERBOSE1:ads_serve.cc(38)] Download catalog
[3831:3831:0810/144009.671953:VERBOSE2:ads_serve.cc(39)] GET /v3/catalog
[3831:3831:0810/144009.672007:VERBOSE5:ads_serve.cc(44)] URL Request:
URL: https://ads-serve.brave.com/v3/catalog
Method: GET

* Confirmed Staging catalog v2 does not contain any state-level ads
* Confirmed Staging catalog v3 does contain state-level ads

[srirambv]

Verification passed on OnePlus 6T with Android 10 running 1.12.113 x64 build

• Verified version 1.12.113 gets v3 of the catalog on staging and production:
  Staging 1.12.113
  

  Production 1.12.113
  

• Verified v3 shows state level ads