Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes state level ads being shown on version without state level targeting #6016

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 7, 2020

Resolves brave/brave-browser#10557

Submitter Checklist:

Test Plan:

See brave/brave-browser#10557

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey
Copy link
Collaborator Author

tmancey commented Jul 7, 2020

CI failed on all platforms during init, restarting

@tmancey
Copy link
Collaborator Author

tmancey commented Jul 7, 2020

CI failed due to audit deps

@tmancey tmancey merged commit db1028e into master Jul 7, 2020
@tmancey tmancey deleted the issues/10557 branch July 7, 2020 13:54
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

State level ads being shown on version without state level targeting
2 participants