Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Drive does not play mp4 video #1122

Closed
LaurenWags opened this issue Sep 13, 2018 · 26 comments
Closed

Google Drive does not play mp4 video #1122

LaurenWags opened this issue Sep 13, 2018 · 26 comments

Comments

@LaurenWags
Copy link
Member

Description

Google Drive will not play .mp4 video. Disabling shields and attempting to play the video does not allow video to be played and console shows errors.

Steps to Reproduce

  1. Clean profile 0.55.3
  2. Login to Google Drive
  3. Attempt to play an .mp4 file --> see notification in URL bar about autoplay being blocked. (autoplay allowed but URL bar still reads autoplay blocked #1120)
  4. Click on this and choose to Always Allow, video still will not play, console errors.
  5. Put shields down, video still will not play, console errors.

Actual result:

mp4 video will not play (shields up or down):
screen shot 2018-09-13 at 12 52 59 pm

console errors: https://gist.github.com/LaurenWags/bda1b03eaeda8a3b8060b68cfd01ff8b#file-autoplay-txt

Expected result:

Video should play, no console errors.

Reproduces how often:

easily

Brave version (chrome://version info)

Brave | 0.55.3 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)
Revision | ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS | Mac OS X

Reproducible on current release:

no, does not reproduce on 0.23.107

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Is the issue reproducible on the latest version of Chrome? no

Additional Information

Reproduced by @srirambv on Win.

Found while testing #833

@bbondy
Copy link
Member

bbondy commented Sep 14, 2018

Does this work on browser-laptop?

@darkdh
Copy link
Member

darkdh commented Sep 14, 2018

Does it play after you choose "Always allow" and click "Done" then do a manual refresh?
This kind of dropdown dialog has a general defect which is it will not auto refresh/or prompt to reload when setting changed.
screen shot 2018-09-13 at 20 13 53
Some content settings required to reload the page when setting changed not just limited to autoplay.

@LaurenWags
Copy link
Member Author

@bbondy tested on browser-laptop with 0.23.107 worked without issue. Steps:

  1. Clean profile on 0.23.107 (release version)
  2. Login to Google Drive
  3. Double click on an .mp4 file --> file displays and plays without issue.

@LaurenWags
Copy link
Member Author

@darkdh I don't see that message displayed. I don't get an Autoplay prompt at all (to the left of the URL bar) like I would expect. I only see the message to the right telling me Autoplay is blocked:

screen shot 2018-09-14 at 9 48 19 am

When I click on that I change the radio button to Always Allow and nothing happens. Reloading the page has no effect - I am still unable to play the mp4 file (shields up or down).

screen shot 2018-09-14 at 9 49 12 am

If you want to look at this together let me know.

@bsclifton
Copy link
Member

This should be working, per having the following set:

proprietary_codecs: true,
ffmpeg_branding: "Chrome",

@bbondy
Copy link
Member

bbondy commented Oct 2, 2018

This is also happening on Android so moving this to the backlog since it doesn't seem like it would stunt growth relative to other issues.

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Oct 2, 2018
@bridiver bridiver assigned bridiver and jumde and unassigned bridiver Oct 2, 2018
@bridiver
Copy link
Contributor

bridiver commented Oct 2, 2018

This looks like fingerprinting protection is not getting disabled with shields down

@bridiver
Copy link
Contributor

bridiver commented Oct 2, 2018

I think we should fix the value to 100%

@bridiver
Copy link
Contributor

bridiver commented Oct 2, 2018

fixing the battery api does not fix the problem per @bbondy, but if we are moving forward with fixing to 100% we should open a new ticket

@jonathansampson
Copy link
Contributor

We appear to still be having issues here.

Version:

Brave 0.56.15 Chromium: 70.0.3538.110 (Official Build) (64-bit)
Revision ca97ba107095b2a88cf04f9135463301e685cbb0-refs/branch-heads/3538@{#1094}
OS Windows
JavaScript V8 7.0.276.40
Flash 31.0.0.153 C:\WINDOWS\system32\Macromed\Flash\pepflashplayer64_31_0_0_153.dll
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36
Command Line "C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe" --enable-tab-audio-muting --disable-domain-reliability --disable-chrome-google-url-tracking-client --no-pings --enable-features=EnableEmojiContextMenu,DesktopPWAWindowing,fill-on-account-select,NewExtensionUpdaterService --disable-features=SharedArrayBuffer,DefaultEnableOopRasterization,VizDisplayCompositor,AutofillSaveCardSignInAfterLocalSave,kAutofillServerCommunication --flag-switches-begin --flag-switches-end
Executable Path C:\Program Files (x86)\BraveSoftware\Brave-Browser\Application\brave.exe

Steps:

  1. Visit https://drive.google.com/file/d/1IjafCgR2HWBDzB-s6XTeCZtXFUM2lXcH/view
  2. Attempt to play the video
  3. Lower shields
  4. Attempt to play the video

Note that the video does not play in Brave Core.

@eljuno
Copy link

eljuno commented Dec 5, 2018

@LaurenWags
Copy link
Member Author

Reopening as there's no PR attached and I am still seeing this issue on

Brave 0.71.90 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

@cliffordp
Copy link

Same on Mac OS X Catalina (10.15)
Brave version 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)

@pfoxsounds
Copy link

Having this issue with Mac OS 10.12.6 (16G2136)
Brave 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)

@timelessthee
Copy link

Also still having this issue on:
Mac OS 10.14.6 (18G103)
Version 0.69.135 Chromium: 77.0.3865.120 (Official Build) (64-bit)

@bizfreak22
Copy link

Also having this issue on:
Mac OS 10.15.1 (19B88)
Version 0.71.112 Chromium: 78.0.3904.87 (Official Build) beta (64-bit)

@scrubdaddytm
Copy link

After updating to v1.0.0 I'm no longer experiencing this bug :)

macOS 10.14.6 (18G95)
Version 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)

@pfoxsounds
Copy link

Fixed for me as well

Mac OS 10.12.6 (16G2136)
Version 1.0.0 Chromium: 78.0.3904.97 (Official Build) (64-bit)

@bsclifton
Copy link
Member

bsclifton commented Nov 19, 2019

@bizfreak22 @timelessthee @cliffordp can you please try updating to the latest version (if you haven't already) and then try this again? 😄

@ryanbr
Copy link

ryanbr commented Nov 26, 2019

I've tested this, seems to work only when allowing 'Allow all cookies' in shields.

@ryanbr
Copy link

ryanbr commented Feb 13, 2020

From a new profile Brave Beta (Version 1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit))

Just for the record of the cookies are being blocked in google drive:

drive-google

@ryanbr
Copy link

ryanbr commented Feb 13, 2020

  1. Tested with Brave Beta, removed old profile.
  2. Logged into gmail, click on the google drive link (top right)
  3. View cookies on google drive. see Allowed/blocked items.

Not sure how reproducible it is, closing and re-opening seems to change this

@pes10k
Copy link
Contributor

pes10k commented Apr 20, 2020

I believe this should be closed as of brave/referrer-whitelist#26.

There may be additional issues here (could be additional cookie related issues) but getting the referrer part straightened out is at least a necessary, if not sufficient, step

@pes10k
Copy link
Contributor

pes10k commented Apr 22, 2020

This requires additional storage exceptions for as added in brave/brave-core#5313

pes10k added a commit to brave/brave-core that referenced this issue Apr 22, 2020
bridiver pushed a commit to brave/brave-core that referenced this issue Apr 27, 2020
@cryptogrounds
Copy link

cryptogrounds commented Apr 27, 2020

Still an issue.
Edit: Disabling shield finally got it to work, but this only works if video is added to drive, otherwise you cannot watch videos from google classroom (probably a separate issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.