Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugins FP blocking not working correctly when FP set to Standard #11278

Closed
LaurenWags opened this issue Aug 17, 2020 · 3 comments · Fixed by brave/brave-core#6472
Closed

Plugins FP blocking not working correctly when FP set to Standard #11278

LaurenWags opened this issue Aug 17, 2020 · 3 comments · Fixed by brave/brave-core#6472
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #9435

When testing on our QA test pages for FP farbling, I noticed that if FP is set to Standard, "Plugins" does not appear to be working correctly. Note, if you set FP to Strict, this is working as expected.

This does not occur in 1.12.x, but does occur in 1.13.x and 1.14.x

Per discussion with @pes10k logging this and tagging @pilgrim-brave to hopefully take a look.

Steps to Reproduce

  1. Clean profile 1.13.x, do not adjust shields
  2. Navigate to https://dev-pages.bravesoftware.com/farbling.html (and/or https://dev-pages.brave.software/farbling.html)
  3. Generate Fingerprints
  4. Look at the line for Plugins

Actual result:

This Page and Remote Frame values are the same, but Local Frame value is different.
1 13 x - initial check - default shields

Expected result:

All three, This Page, Local Frame, and Remote Frame, should the the same on the Plugins line on a given page (but these values should be different between the two pages) as they do in 1.12.x:
1 12 x - plugins

When retesting, confirm Strict setting in shields still works as expected.

Reproduces how often:

easily

Desktop Brave version:

Brave 1.13.73 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, does not reproduce on 1.12.x
  • Can you reproduce this issue with the beta channel? yes, 1.13.x
  • Can you reproduce this issue with the nightly channel? yes 1.14.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @pes10k @brave/legacy_qa @rebron

Note - tagged as OS/Android since original issue was also tagged as Android, please remove if this does not apply.

@LaurenWags LaurenWags added privacy feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes regression OS/Android Fixes related to Android browser functionality privacy-pod Feature work for the Privacy & Web Compatibility pod OS/Desktop labels Aug 17, 2020
@pes10k pes10k added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 18, 2020
@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - 1.13.77

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 18, 2020

Verification passed on


Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


  • Verified the STR from the description and ensured that the Plugin value is the same for This Page, Local Frame, and Remote Frame
https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
image image

Verification passed on

Brave 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
Revision ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS Ubuntu 18.04 LTS
  • Verified the STR from the description and ensured that the Plugin value is the same for This Page, Local Frame, and Remote Frame
https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
image image

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.15.56 Chromium: 85.0.4183.102 (Official Build) dev (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Verified the STR as per #11278 (comment) and ensured that the Plugin value is the same for This Page, Local Frame, and Remote Frame when using Fingerprinting blocked (Standard) as per the following:

https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
Screen Shot 2020-09-23 at 12 10 01 AM Screen Shot 2020-09-23 at 12 08 43 AM

Verified the STR as per #11278 (comment) and ensured that the Plugin value is the same for This Page, Local Frame, and Remote Frame when using Fingerprinting blocked (strict, may break sites) as per the following:

https://dev-pages.bravesoftware.com/farbling.html https://dev-pages.brave.software/farbling.html
Screen Shot 2020-09-23 at 12 12 14 AM Screen Shot 2020-09-23 at 12 13 15 AM

@srirambv
Copy link
Contributor

srirambv commented Sep 22, 2020

Verification passed on OnePlus 6T with Android 10 running 1.15.54 x64 beta build

  • Verified plugins value is the same on both the pages with FP set to block all and block cross-site fingerpriting
https://dev-pages.bravesoftware.com/farbling.html (Block cross-site) https://dev-pages.bravesoftware.com/farbling.html (Block all) https://dev-pages.brave.software/farbling.html (Block cross-site) https://dev-pages.brave.software/farbling.html (Block all)
image image image image

Verification passed on Samsung Tab A with Android 10 running 1.15.54 x64 beta build

  • Verified plugins value is the same on both the pages with FP set to block all and block cross-site fingerpriting
https://dev-pages.bravesoftware.com/farbling.html (Block cross-site) https://dev-pages.bravesoftware.com/farbling.html (Block all) https://dev-pages.brave.software/farbling.html (Block cross-site) https://dev-pages.brave.software/farbling.html (Block all)
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants