Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark button colour doesn't update when switching between dark/light theme #1170

Closed
srirambv opened this issue Sep 18, 2018 · 3 comments · Fixed by brave/brave-core#501
Closed

Comments

@srirambv
Copy link
Contributor

Description

Bookmark button colour doesn't update when switching between dark/light theme

Steps to Reproduce

  1. Set browser theme to dark/default
  2. Change theme to light
  3. Bookmark button doesn't change colour unless you click it

Actual result:

bmkbtn

Expected result:

Should change similar to other URL bar buttons

Reproduces how often:

100%

Brave version (chrome://version info)

Brave 0.55.4 Chromium: 70.0.3538.12 (Official Build) dev (64-bit)
Revision ad61584ca32115f953ce656dd75b44f1c502a75d-refs/branch-heads/3538@{#179}
OS Windows

Reproducible on current release:

NA

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#974
cc: @kjozwiak @LaurenWags to verify on macOS

@LaurenWags
Copy link
Member

Reproduced on macOS using 0.55.4

@bbondy
Copy link
Member

bbondy commented Sep 27, 2018

@petemill merged label is only needed for PR. Thanks.

@LaurenWags
Copy link
Member

LaurenWags commented Oct 8, 2018

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified toggle between GTK+ and Classic theme on Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment