Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breakage on some sites that use addthis scripts #11744

Closed
antonok-edm opened this issue Sep 16, 2020 · 2 comments · Fixed by brave/brave-core#6658
Closed

Fix breakage on some sites that use addthis scripts #11744

antonok-edm opened this issue Sep 16, 2020 · 2 comments · Fixed by brave/brave-core#6658

Comments

@antonok-edm
Copy link
Collaborator

Some websites that use the addthis_widget.js script, e.g. https://www.rhmodern.com/catalog/product/product.jsp?productId=prod14970086&categoryId=cat7150028, do not function as expected.

This is due to an inconsistency between how adblock-rust and uBO handle redirect and important rules. More information on the discrepancy can be found here. This should be fixed by updating adblock-rust.

@antonok-edm antonok-edm added bug feature/shields/adblock Blocking ads & trackers with Shields OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 16, 2020
@antonok-edm antonok-edm self-assigned this Sep 16, 2020
@antonok-edm antonok-edm added this to the 1.16.x - Nightly milestone Sep 18, 2020
@btlechowski
Copy link

btlechowski commented Sep 30, 2020

Verification passed on

Brave 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

Reproduced the issue on 1.15.x
image

Verified the test plan from brave/brave-core#6658
image

Verification PASSED on macOS 10.15.16 x64 using the following version:

Brave | 1.16.47 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.15.6 (Build 19G73)

Went through the STR/Cases outlined via brave/brave-core#6658 (comment) as per the following:

Example of 1.15.x Example of 1.16.x
Screen Shot 2020-09-29 at 9 39 10 PM Screen Shot 2020-09-30 at 11 42 00 AM

Verification passed on


Brave | 1.16.58 Chromium: 86.0.4240.75 (Official Build) dev (64-bit)
-- | --
Revision | c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS | Windows 10 OS Version 1903 (Build 18362.1082)


Reproduced in 1.15.x
image

Verified the test plan from brave/brave-core#6658
image

@srirambv
Copy link
Contributor

Verification passed on the following device running 1.16.69 x64 build

  • Verified image is loaded as expected
OnePlus 6T Samsung Tab A
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants