Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 70.0.3528.4 to 70.0.3538.12 #953

Merged
merged 1 commit into from
Sep 9, 2018
Merged

Upgrade from Chromium 70.0.3528.4 to 70.0.3538.12 #953

merged 1 commit into from
Sep 9, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Sep 4, 2018 •
edited
Loading

Fix #952

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@bbondy bbondy added this to the Releasable builds 0.55.x milestone Sep 4, 2018
@bbondy bbondy assigned bridiver and bbondy and unassigned bridiver Sep 4, 2018
@bbondy bbondy requested a review from bridiver September 4, 2018 20:54
bridiver
bridiver previously approved these changes Sep 4, 2018
View reviewed changes
@bbondy bbondy changed the title Upgrade from Chromium 70.0.3528.4 to 70.0.3538.6 Upgrade from Chromium 70.0.3528.4 to 70.0.3538.7 Sep 5, 2018
@bbondy bbondy changed the title Upgrade from Chromium 70.0.3528.4 to 70.0.3538.7 Upgrade from Chromium 70.0.3528.4 to 70.0.3538.8 Sep 5, 2018
@bbondy bbondy changed the title Upgrade from Chromium 70.0.3528.4 to 70.0.3538.8 Upgrade from Chromium 70.0.3528.4 to 70.0.3538.12 Sep 9, 2018
@bbondy bbondy merged commit 7e9c9ff into master Sep 9, 2018
@bbondy
Copy link
Member Author

bbondy commented Sep 9, 2018

Previously passed review, all builds and tests pass on every platform.

bbondy added a commit that referenced this pull request Sep 9, 2018
@bbondy
Merge pull request #953 from brave/70.0.3538.6
909fcf3 
Upgrade from Chromium 70.0.3528.4 to 70.0.3538.12
@bbondy
Copy link
Member Author

bbondy commented Sep 9, 2018 •
edited
Loading

0.55.x 909fcf3

@bbondy bbondy added the 0.55.x label Sep 9, 2018
@bsclifton bsclifton deleted the 70.0.3538.6 branch September 10, 2018 17:01
@bbondy bbondy removed the 0.55.x label Jan 14, 2019
@LaurenWags LaurenWags mentioned this pull request Sep 25, 2020
Closed
This was referenced Sep 25, 2020
Closed
Closed
Closed
Closed
Closed
@LaurenWags LaurenWags mentioned this pull request Sep 28, 2020
Closed
@rebron rebron mentioned this pull request Sep 28, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Sep 29, 2020
Closed
@LaurenWags LaurenWags mentioned this pull request Sep 29, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Sep 29, 2020
Closed
This was referenced Sep 30, 2020
Closed
Closed
Closed
Closed
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this pull request Sep 30, 2020
Closed
@btlechowski btlechowski mentioned this pull request Sep 30, 2020
Closed
@LaurenWags LaurenWags mentioned this pull request Sep 30, 2020
Closed
@prakharb5 prakharb5 mentioned this pull request Oct 1, 2020
Closed
This was referenced Oct 1, 2020
Closed
Closed
Closed
@srirambv srirambv mentioned this pull request Oct 2, 2020
Closed
This was referenced Oct 2, 2020
Closed
Closed
@ilyaigpetrov ilyaigpetrov mentioned this pull request Oct 3, 2020
Closed
This was referenced Oct 5, 2020
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver left review comments

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging this pull request may close these issues.
2 participants
@bbondy @bridiver