Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out Vero's email tracker from URLs #11817

Closed
fmarier opened this issue Sep 22, 2020 · 5 comments · Fixed by brave/brave-core#6684
Closed

Filter out Vero's email tracker from URLs #11817

fmarier opened this issue Sep 22, 2020 · 5 comments · Fixed by brave/brave-core#6684
Assignees
@fmarier
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.16.x - Release #1

Comments

@fmarier
Copy link
Member

fmarier commented Sep 22, 2020

The Vero messaging platform uses a vero_id query string parameter to annotate third-party URLs with "the unique ID of the user who has clicked the link."

The purpose for this is described in their documentation:

Adding this parameter enables Vero’s Javascript library to automatically identify a user when they land on your site, even if they are not already identified. This enables cross-device tracking and ensures a more complete and accurate customer profile.

They do offer the option of removing that parameter from URLs and explain its effect:

When disabling appending vero_id to your campaigns, Vero’s Javascript library will no longer automatically identify users when they click through from an email.

Therefore stripping out this parameter should have no webcompat implications.
@fmarier fmarier added privacy priority/P3 The next thing for us to work on. It'll ride the trains. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Sep 22, 2020
@fmarier fmarier self-assigned this Sep 22, 2020
@fmarier
Copy link
Member Author

fmarier commented Sep 22, 2020

Here are some examples which can be found via Google:

  • https://www.deckofscarlet.com/log-in/register?utm_campaign=111918_blackfridaylaunch_nonsub&utm_medium=calendar&utm_source=news_email&vero_conv=kGnF6SYO5V3PbgXsIwwUNNSlWBCantgnVkvEntSFodpp9KFpEtU1XkYCSUxltJuvF-vHne1MoYngHSVmfEhhgv-9xgptCmn3&vero_id=85422
  • https://monosnap.com/welcome?utm_term=Newsletter&utm_campaign=[cold%20%2B%20warm]%20-%20newsletter%20-%20120916&utm_medium=email&vero_conv=O9KWzIj7BNysHI2T7J1L_g81x55Zg-Plp2IFXHaQqgjN-LUS3EqpJA96okHkrmAx61aSrdscSPiraCHu_w1Fot9ygp2tCco8&vero_id=3492441&utm_source=vero&utm_content=control&__hstc=20629287.99a265337744294b740e0787aea508c4.1570320001226.1570320001227.1570320001228.1&__hssc=20629287.1.1570320001229&__hsfp=3733277192
  • https://www.mailerlite.com/?utm_campaign=[cold+%2B+warm]+-+newsletter+-+120916&utm_medium=email&utm_term=Newsletter&__hstc=20629287.99a265337744294b740e0787aea508c4.1570320001238.1570320001239.1570320001240.1&__hssc=20629287.1.1570320001241&_ga=2.108145861.670349201.1555516136-933118289.1529345498&yt_video=PNrnO31OD5M&region=united-states&vero_conv=O9KWzIj7BNysHI2T7J1L_g81x55Zg-Plp2IFXHaQqgjN-LUS3EqpJA96okHkrmAx61aSrdscSPiraCHu_w1Fot9ygp2tCco8&vero_id=3492441&__hsfp=3733277192&utm_source=vero&utm_content=control
  • https://www.brightcove.com/en/online-video-platform?utm_term=Newsletter&utm_campaign=[cold+%2B+warm+-+last+60]+-+newsletter+-+012916&utm_medium=email&vero_conv=O9KWzIj7BNysHI2T7JxO-eOelX_hAg8Ws1OR04J-KL7HZHjLFyTAm1bK7mPlbInhSiw-sAGUPpUqi9VQ24MXgELWp20pTUo%3D&vero_id=3368475&utm_content=control&utm_source=vero&__hstc=259582869.99a265337744294b740e0787aea508c4.1576108800148.1576108800149.1576108800150.1&__hssc=259582869.1.1576108800151&__hsfp=3969827736&_ga=2.250809862.1607566148.1585586557-1753121421.1568128919&hubs_signup-url=blog.hubspot.com/website/css-margin-vs-padding&hubs_signup-cta=blog-card__blog-link
  • https://galaxystore.samsung.com/detail/com.vsco.cam.samsung?utm_term=Newsletter&utm_campaign=[cold+%2B+warm]+-+newsletter+-+120916&utm_medium=email&_ga=2.108145861.670349201.1555516136-933118289.1529345498&yt_video=pZl62ZJSNbc&region=united-states&vero_conv=O9KWzIj7BNysHI2T7J1L_g81x55Zg-Plp2IFXHaQqgjN-LUS3EqpJA96okHkrmAx61aSrdscSPiraCHu_w1Fot9ygp2tCco8&vero_id=3492441&utm_source=vero&utm_content=control&session_id=W_64a278a33667d5de901961be3c464b76

It's pretty odd that the last 4 have the same value for vero_id and vero_conv. I couldn't find any indication of what might be contained in vero_conv (it doesn't return anything readable after base64-decoding it), but based on the name, I would guess it has to do with conversion tracking.

fmarier added a commit to brave/brave-core that referenced this issue Sep 22, 2020
@fmarier
Filter Vero email trackers out of URLs (fixes brave/brave-browser#11817…
d40f6ab 
…).
@fmarier fmarier mentioned this issue Sep 22, 2020
Merged
32 tasks
@fmarier fmarier added this to the 1.16.x - Nightly milestone Sep 23, 2020
@btlechowski
Copy link

btlechowski commented Sep 30, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.15.63 Chromium: 86.0.4240.55 (Official Build) dev (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

The issues is still reproducible, it seems that the filtering does not work in general. Logged #11924. Based on our process I mark this issue as verified.

image

Verification passed on


Brave | 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verified using

Brave | 1.16.50 Chromium: 86.0.4240.55 (Official Build) dev (x86_64)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | macOS Version 10.14.6 (Build 18G3020)

Using test plan from brave/brave-core#6684, confirmed issue still reproduces as mentioned above.

Screen Shot 2020-10-02 at 3 26 53 PM

@LaurenWags
Copy link
Member

Marking as release-notes/exclude as issue still reproduces, please adjust if necessary cc @rebron

@fmarier
Copy link
Member Author

fmarier commented Oct 2, 2020

Marking as release-notes/exclude as issue still reproduces, please adjust if necessary cc @rebron

As I mentioned in #11578 (comment), this is partially working and the remaining issue is tracked elsewhere.

deeppandya pushed a commit to brave/brave-core that referenced this issue Oct 7, 2020
@fmarier @deeppandya
Filter Vero email trackers out of URLs (fixes brave/brave-browser#11817…
23c176b 
…).
@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build

Verification passed on OnePlus 6 with Android 10 running 1.16.69 x64 build

@LaurenWags LaurenWags mentioned this issue Oct 26, 2020
Closed
@kjozwiak kjozwiak mentioned this issue Oct 26, 2020
Closed
lyubomyr-shaydariv added a commit to lyubomyr-shaydariv/uu-webext that referenced this issue Jun 15, 2024
@lyubomyr-shaydariv
https://github.com/brave/brave-browser/issues/11817
d9128e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmarier fmarier

Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter privacy QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.16.x - Release #1
Development

Successfully merging a pull request may close this issue.

Filter Vero email trackers out of URLs brave/brave-core
5 participants
@fmarier @srirambv @LaurenWags @btlechowski @GeetaSarvadnya