Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exempt intra-site requests from the query string filter #9020

Closed
fmarier opened this issue Apr 4, 2020 · 2 comments · Fixed by brave/brave-core#6609
Closed

Exempt intra-site requests from the query string filter #9020

fmarier opened this issue Apr 4, 2020 · 2 comments · Fixed by brave/brave-core#6609
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@fmarier
Copy link
Member

fmarier commented Apr 4, 2020

We have in brave-core a query string filter which removes parameters known to be tracking individuals.

While the existing ones are pretty unlikely to conflict with legitimate query string parameters, some of the proposed ones are generic enough that they might break sites which use them for non-tracking purposes.

We are proposing the following change to the query string filter: exempt same-site requests from the filter.

@fmarier fmarier added the privacy-pod Feature work for the Privacy & Web Compatibility pod label Apr 4, 2020
@fmarier fmarier added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 23, 2020
@fmarier fmarier self-assigned this Sep 3, 2020
@fmarier fmarier added this to the 1.16.x - Nightly milestone Sep 23, 2020
@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 23, 2020
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 30, 2020

Verification passed on


Brave | 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
-- | --
Revision | a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

Verifications for Redirected same-site tests
  • Verified that the fbclid parameter is present on the landing page, and the gclid parameter is missing in the intermediate step.
    image
    image
Verifications for Same-site tests
  • Verified that the fbclid parameter is present on the landing page.
    image
    image

Verification passed on

Brave 1.16.46 Chromium: 86.0.4240.55 (Official Build) nightly (64-bit)
Revision a6d625ef6f7fe8ea0675f1cf759155a05ee1be40-refs/branch-heads/4240@{#953}
OS Ubuntu 18.04 LTS

Verified passed with

Brave | 1.16.52 Chromium: 86.0.4240.68 (Official Build) dev (x86_64)
-- | --
Revision | ad72ee9aa8e15ed300df1238e76c7a8f4d686f97-refs/branch-heads/4240@{#1097}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6609

Encountered #11924 and #11930

@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.16.69 x64 build


Verification passed on OnePlus 6T with Android 10 running 1.16.69 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. privacy/query-filter privacy privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants