Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccountConsistencyMethod should default to disabled on Android #12319

Closed
jumde opened this issue Oct 26, 2020 · 2 comments · Fixed by brave/brave-core#6956 or brave/brave-core#7081
Closed

Comments

@jumde
Copy link
Contributor

jumde commented Oct 26, 2020

Description

Android defaults to Mirror as the account consistency method. This should be explicitly set to disabled till extensions are enabled on android.

Steps to reproduce

  1. Navigate to brave://signin-internals

Actual result

account consistency method is Mirror

Expected result

account consistency method should be none

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.15.76

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@jumde
Copy link
Contributor Author

jumde commented Nov 3, 2020

Fix reverted - causes DCHECK failure - brave/brave-core#7040

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.18.51 x64 beta build

  • Verified Account Consistency is set to none
    image

Verification passed on Samsung Tab A with Android 10 running 1.18.51 x64 beta build

  • Verified Account Consistency is set to none
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment