Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 99.0.4844.35 to Chromium 99.0.4844.45. #21280

Closed
mkarolin opened this issue Feb 23, 2022 · 6 comments · Fixed by brave/brave-core#12383
Closed

Upgrade from Chromium 99.0.4844.35 to Chromium 99.0.4844.45. #21280

mkarolin opened this issue Feb 23, 2022 · 6 comments · Fixed by brave/brave-core#12383

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/99.0.4844.35..99.0.4844.45?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@LaurenWags
Copy link
Member

@brave/legacy_qa please check all "Affected Areas" for desktop and android from #20477 (comment) if not already verified with Chromium 99.

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 24, 2022

Verification completed on 1.36.105, Chromium 99.0.4844.45

Device: Samsung Galaxy S21 | Android 12

Per #20477 (comment)
PASS - Stack overview mode removed (#21005)
PASS - New tab page UI
PASS - Account Consistency (double check this still works #12319)
PASS - Bottom toolbar icons
PASS - Top toolbar UI
PASS - Overview mode UI
PASS - Private tab UI

Per #21280 (comment)
PASS - Check branding items
PASS - Check for version bump

Screen Shot 2022-02-24 at 10 42 14 AM


Verification passed on Samsung Tab A with Android 10 running 1.36.105 x64 build

  • Verified Private tab UI looks fine
  • Verified New Tab Page UI looks fine
  • Verified Account consistency section works fine
  • Verified no branding items are changed

@LaurenWags
Copy link
Member

LaurenWags commented Feb 25, 2022

Verified using:

Brave	1.36.106 Chromium: 99.0.4844.45 (Official Build) (x86_64) 
Revision	edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS	macOS Version 12.2.1 (Build 21D62)

Verified Desktop Affected Areas from #20477 (comment)

Sync works for newly created profiles

Confirmed able to create a sync chain using 1.36.x w/ C99
Confirmed able to join a sync chain using 1.36.x w/ C99
Confirmed able to sync bookmarks, history, passwords between two desktop profiles
Additional tests to be covered during full manual pass on macOS

Component updater

Confirmed no components showed "Error" on clean profile in 1.36.x w/ C99
Waited 8 minutes after loading profile, confirmed no components showed "Error"
Confirmed all components had a version number
Additional tests to be covered during full manual pass on macOS

Settings UI / History / Bookmarks - styling changes

Verified History UI via #21259 (comment)
Confirmed when history is synced (typed URLs) from another device they display on brave://history
Confirmed that history is shown for the visited websites in brave://history

History

Confirmed bookmarks can be imported
Confirmed bookmarks can be added/edited/deleted
Confirmed imported bookmarks can be opened

Bookmarks

General spot check of Settings UI
Confirmed able to open "sub pages" (ex. Nav to brave://settings/privacy and open the cookies section)
Confirmed able to expand sections (ex. Navigate to brave://settings/languages and expand Language field)

AdBlock regional preferences settings

Confirmed when my OS was set to the country/language below, the associated Adblock lists were checked by default on brave://adblock

France/French Italy/Italian Germany/German
French Italian German
Brave Today Preferences
  • Confirmed click on Show Brave News shows the brave news feeds
  • Confirmed content cards are loading the images correctly in feeds when the brave news feed is scrolled down
  • Confirmed click on any image/link on news feed redirects to correct target link
  • Confirmed images render properly on brave news feeds when any publisher is enabled/disabled via Sources
  • Confirmed Brave News/feeds will not be shown when the Brave News switch is disabled
  • Confirmed Brave News settings in Customize dashboard are retained after browser restart
Binance (verified by @srirambv)
  • Verified Binance account is still logged in upon upgrade
  • Verified Binance summary view state (show/hide balance) is retained upon upgrade
  • Verified balance is updated every 30 sec
  • Encountered <#21258> which seems to be an existing issue on 1.36.66 as well
Wallet (verified by @srirambv)
  • Verified wallet account is retained upon upgrade
  • Verified connecting Ledger wallet works fine and able to import accounts on both Live and Legacy
  • Verified connecting Trezor wallet works fine and able to import accounts
  • Verified able to submit transactions and approve/reject via hardware wallet
  • More verification done via #18833 (comment) & #21171 (comment)
Handling of external URLs (including magnet)

Confirmed able to load magnet links
Confirmed able to load .torrent links
Used https://webtorrent.io/free-torrents to get these files for testing

Confirmed loading ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html showed the IPFS interstitial page

Confirmed loading ipns://brantly.eth showed the IPFS interstitial page

Opening Guest and Tor windows from ☰ and context menus

Confirmed able to open Guest indow from hamburger menu
Confirmed able to open Tor window from hamburger menu
Confirmed able to open Private window from hamburger menu

Confirmed able to open Tor window from context menu
Confirmed able to open Private window from context menu

Confirmed able to open Tor window from keyboard shortcut (Shift + Cmd + N)
Confirmed able to open Private window from keyboard shortcut (Opt + Cmd + N)

Confirmed able to open site in Tor window from the "Tor" button in URL bar (button is shown when .onion site available)

Extensions WebUI

Confirmed installed extensions are shown in brave://extensions/
Enabled Allow in Private settings in manage extensions and ensured extension is shown in the Private tab
Confirmed extension web UI is shown as expected in Private tab
Confirmed extensions can be removed

Speedreader

Confirmed enabling #brave-speedreader flag in brave://flags shows a setting under brave://settings/appearance
Confirmed enable speed-reader switch in brave://settings/appearance enables the speed reader mode on webpage/article
Confirmed speed-reader icon is shown in the URL bar
Confirmed speed-reader icon is retained on the webpage upon browser restart
Confirmed webpage/article is displayed in the reader mode when the speed-reader switch is enabled
Confirmed able to toggle speed-reader on/off for a particular site using the URL bar button

Pages using brave:// scheme showing correct URL and loading

Confirmed various brave:// pages loaded as expected
Confirmed visiting a chrome:// page redirected to brave:// version and loaded as expected

Check brave://flags page to make sure Brave features are listed

Confirmed various Brave features are listed on flags page

Screen Shot 2022-02-25 at 3 30 27 PM

@stephendonner
Copy link

stephendonner commented Feb 25, 2022

Verification PASSED using

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (x86_64)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS macOS Version 11.6.3 (Build 20G415)
Sync works for newly created profiles:

Confirmed I could do the following:

  • create Sync chain
  • join Sync chain
  • left Sync chain
  • re-joined chain
brave://components

Confirmed components were present, had version numbers, and a status of either NEW, UPDATED, or UP-TO-DATE.
Confirmed clicking on Check for update flashes Checking... and finally Component not updated
Confirmed brave://components still had no errors after 8 minutes

AdBlock regional preferences settings
Confirmed that the appropriate country/language-specific filter list was selected via `brave://adblock`.

Tested: en-US, DE, UA.

Brave News preferences

Checked the following and confirmed they worked:

  • opt-in
  • remove feed source
  • add feed source
  • add/remove (different) sources at the same time
  • add a custom RSS feed source
  • confirmed inline-content ad rendered
Handling of external URLs (including magnet)

Checked the following and ensure it worked:

Opening Guest and Tor windows from ☰ and context menus

Checked the following and ensured they worked:

  • ☰ -> File | New Private Window
  • ☰ -> File | New Private Window with Tor
  • ☰ -> Open Guest Window
  • context-click -> Open Link in Private Window
  • context-click -> Open link in Private Window with Tor
Extensions WebUI
Speedreader

Steps:

  • load nbc.com
  • clicked on the Speedreader icon in the URL bar
  • clicked on the Turn on Speedreader button

Cconfirmed article rendered in Speedreader mode
Confirmed Speedreader pref in brave://settings was flipped to On

Encountered:

Pages using brave:// scheme showing correct URL and loading

Checked the following and ensured they worked:

  • brave://bookmarks
  • brave://history/
  • brave://ipfs-internals/
  • brave://rewards/
  • brave://rewards-internals/
  • brave://settings/clearBrowserData
Settings UI / History / Bookmarks - styling changes

Spot-checked brave://settings for general appearance, usability, and correctness.

Confirmed when history is synced (typed URLs) from another device they display on brave://history.
Confirmed that history is shown for the visited websites in brave://history.
Confirmed dialogs were correct and worked.
Confirmed context-menu items on bookmarks and history items.
Confirmed bookmarks can be imported.
Confirmed bookmarks can be added/edited/deleted.
Confirmed imported bookmarks can be opened.

Check brave://flags page to make sure Brave features are listed:

Confirmed I could find Brave-specific feature flags, such as:

  • SKU
  • Easylist

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 25, 2022
@MadhaviSeelam
Copy link

Verified 'Passed' using

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS Windows 11 Version 21H2 (Build 22000.493)
Sync works for newly created profiles:

Verified following:

  • Confirmed when history is synced (typed URLs) from another device they display on brave://history.
  • Confirmed that history is shown for the visited websites in brave://history.
  • Confirmed context-menu items on bookmarks and history items.
  • Bookmarks can be imported.
  • Bookmarks can be added/edited/deleted.
  • Imported bookmarks can be opened.
  • Spot-checked brave://settings for general appearance, usability, and correctness.
  • Able to open "sub pages" (ex. Nav to brave://settings/privacy and open the cookies section)
  • Able to expand sections (ex. Navigate to brave://settings/languages and expand Language field)

example

sync
Settings UI / History / Bookmarks - styling changes Verified following:
  • Confirmed when history is synced (typed URLs) from another device they display on brave://history.
  • Confirmed that history is shown for the visited websites in brave://history.
  • Confirmed context-menu items on bookmarks and history items.
  • Bookmarks can be imported.
  • Bookmarks can be added/edited/deleted.
  • Imported bookmarks can be opened.
  • Spot-checked brave://settings for general appearance, usability, and correctness.
  • Able to open "sub pages" (ex. Nav to brave://settings/privacy and open the cookies section)
  • Able to expand sections (ex. Navigate to brave://settings/languages and expand Language field)
    example | example
    ---|---
    History | Bookmarks
Component updater Verified following:
  • No components showed "Error" on a clean profile
  • Confirmed brave://components showed no errors, after waiting 8 minutes after loading profile
  • All components had a version number
  • Components had a status of either NEW, UPDATED, or UP-TO-DATE

example

Component updater with version numbers
AdBlock regional preferences settings Verified following: brave://adblock for adblock lists when region adblock preferences are set and launched brave browser Tested with --lang=FR , --lang=CZE and --lang=de
example example example
adblockcze adblockfr < adblock
Brave News preferences Verified following:
  • Click on Show Brave News to show brave news feed
  • Scroll down to verify content cards are loading the images correctly in feeds
  • When clicked on link and image on news feed redirects to correct target URL
  • Clicked Customize button to toggle off Show Brave news switch on the dashboard
  • Brave News/feeds are not shown when the brave news switch is still disabled
  • Brave news settings will retain in the customize dashboard after restarting the browser
  • Remove news feed on a content card by disabling publisher name
  • Removing news source from customize dashboard removes content card
Handling of external URLs (including magnet) Verified following:
  • Able to load magnet links and .torrent links using https://webtorrent.io/free-torrents to get these files for testing
  • Confirmed loading ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html showed the IPFS interstitial page
  • Confirmed loading ipns://brantly.eth showed the IPFS interstitial page
Opening Guest and Tor windows from ☰ and context menus Verified following:
  • Able to open Guest window from hamburger menu
  • Able to open Tor window from hamburger menu
  • Able to open Private window from hamburger menu
  • Able to open Tor window from context menu
  • Able to open Private window from context menu
  • Able to open Tor window from keyboard shortcut (Shift + Cmd + N)
  • Able to open Private window from keyboard shortcut (Opt + Cmd + N)
  • Able to open site in Tor window from the "Tor" button in URL bar (button is shown when .onion site available)
Extensions Web UI Verified following:

extension

extension
Speedreader Verified following:
  • Enabled #brave-speedreader flag in brave://flags shows a setting under brave://settings/appearance
  • Enabled speed-reader switch in brave://settings/appearance enables the speed reader mode on webpage/article
  • Speed-reader icon is retained on the webpage upon browser restart
  • Speed-reader icon is shown in the URL bar when clicked an article to load the page
  • Webpage/article is displayed in the reader mode when the speed-reader switch is enabled
  • Able to toggle speed-reader on/off for a particular site using the URL bar button

Encountered: #21273

Pages using brave:// scheme showing correct URL and loading Verified various brave://pages loaded as below
  • brave://bookmarks
  • brave://history/
  • brave://ipfs-internals/
  • brave://rewards/
  • brave://rewards-internals/
  • brave://settings/clearBrowserData
  • Confirmed visiting a chrome:// page redirected to brave:// version and loaded as expected
Check brave://flags page to make sure Brave features are listed Verified following: Various Brave features are listed on flags page example --- braveflags

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 28, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 1, 2022

Removing release-notes/include and adding release-notes/exclude in favour of #21370.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment