Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire stack layout UI for tabs overview mode #21005

Closed
samartnik opened this issue Feb 9, 2022 · 9 comments
Closed

Retire stack layout UI for tabs overview mode #21005

samartnik opened this issue Feb 9, 2022 · 9 comments

Comments

@samartnik
Copy link
Contributor

Description

Now that we have an option to open in a new tab from the context menu brave/brave-core#12149, users are not forced to group tabs anymore. We should retire stack layout UI for overview mode as it requires more and more resources for maintenance.

Steps to reproduce

Actual result

Expected result

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Feb 9, 2022
samartnik added a commit to brave/brave-core that referenced this issue Feb 10, 2022
Resolves brave/brave-browser#21005

Chromium change:
chromium/chromium@94a231f

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
@samartnik
Copy link
Contributor Author

Resolved by brave/brave-core#12201

mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 11, 2022
Resolves brave/brave-browser#21005

Chromium change:
chromium/chromium@94a231f

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 14, 2022
Resolves brave/brave-browser#21005

Chromium change:
chromium/chromium@94a231f

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 16, 2022
Resolves brave/brave-browser#21005

Chromium change:
chromium/chromium@94a231f

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
mkarolin pushed a commit to brave/brave-core that referenced this issue Feb 17, 2022
Resolves brave/brave-browser#21005

Chromium change:
chromium/chromium@94a231f

Remove unused rendering code in TabLayout
Follow up to https://chromium-review.googlesource.com/c/chromium/src/+/3388174
and continues to simplify the Tab rendering logic for phones.

Also deletes anything related to tilting/rotating and card backs for the
tabs.

Bug: 1287653
@srirambv
Copy link
Contributor

This requires a CR99 build on 1.36.x. Fix is part of the CR99 commit.

cc: @Uni-verse

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 24, 2022

Verification completed on release branch 1.36.105, Chromium 99.0.4844.45
PASSED on Samsung Galaxy S21 | Android 12 | ARM

  • Overview UI enabled
  • Removed stack layout UI
  • Removed Group Tabs Toggle in Settings > Appearance
  • User is able to upgrade from C98 to C99 build version successfully with stack view enabled
  • User is able to group tabs
Overview Settings
Screen Shot 2022-02-24 at 11 38 55 AM Screen Shot 2022-02-24 at 11 37 45 AM

@emrys767
Copy link

This is a horrible decision. Many users including myself left Chrome because this stack feature was removed. Please bring this back.

@TheEskir
Copy link

Bruh, I realize this is maintenance effort, but you're gonna have to weigh this effort against the possibility of losing a large chunk of your userbase that only came here from chrome because you didn't do that shit.

@Cryptoflo1
Copy link

Please undo this. I have been completely lost & frustrated after less than a week since tabs were SURPRISINGLY CHANGED to tiles. When chrome did this I completely left & came here. I really like Brave & hope this gets fixed but I can't do this for much longer. It actually opens more tabs than cascade mode. I believe the majority of the community agrees & is ready to change browsers again.

@BringBackCardTabs
Copy link

Created this account just to say that I'm going to another browser if stack layouts are still gone after an update or two. Grid is terrible.

@brave brave deleted a comment from ChrislyBear-GH Mar 31, 2022
@bsclifton
Copy link
Member

Hi folks - issue created for re-adding the "Stack View" here:
#22028

More information about this can be found here:
#21556 (comment)

@Goranaws
Copy link

I absolutely hate the person who made this post. Do not destroy the only feature that made your browser worth switching to in the first place. I will never use Chrome again, so long as grid view is the only option. It shouldn't even be an option, it's trash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests