Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Made context menu option 'Open in new tab' visible #12149

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Feb 4, 2022

Resolves brave/brave-browser#15120

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 4, 2022
@samartnik samartnik added this to the 1.37.x - Nightly milestone Feb 4, 2022
@samartnik samartnik self-assigned this Feb 4, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 12 using 1.37.58 Chromium: 99.0.4844.35

  • ensured that opening links via Open in new tab on websites via the context menu works as expected
  • ensured that tabs opened via Open in new tab are visible in the tab grid layout
  • ensured that tabs opened via Open in new tab can be closed via the tab grid layout without issues
  • ensured that a tab that's active and opened via Open in new tab stays active after several restarts
  • ensured that tabs opened via Open in new tab are retained after restarting the browser several times
  • ensured that openings tabs within PB using Open in new tab doesn't appear in History
  • ensured that you can open tabs using Open in new tab within PB mode without any issues
  • ensured that opening a new tab within a group using Open in new tab opens an independent tab
  • ensured that tabs opened via Open in new tab can be moved into group tabs via the tab grid layout
  • ensured that Open in new tab moved into a tab group and be removed without any issues
  • ensured Open in new tab works via Top Tiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Open in a new tab group is the only option on long press context menu
3 participants