Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add third option to Ledger accounts to support old derivation paths #21171

Closed
spylogsster opened this issue Feb 17, 2022 · 2 comments · Fixed by brave/brave-core#12319
Closed

Comments

@spylogsster
Copy link

Description

Before #19883 we used wrong derivation paths and for compatibility need to add a thrid option to the list as Deprecated (not recommended)

Steps to Reproduce

  1. Install old brave version
  2. Import ledger Legacy account
  3. Update version, reset wallet and try import again, should be able to import same old accounts

Actual result:

old accounts are not visible

Expected result:

old accounts are visible

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@kjozwiak
Copy link
Member

This was originally uplifted/scheduled to go into a 1.35.x HF but never ended up being released. It will go out via 1.36.x as we won't be having another 1.35.x release at this point.

@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Feb 24, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 25, 2022

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (64-bit)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified test plan from brave/brave-core#12319
  • Verified installing older version (1.32.53) and enabling native wallet and importing Ledger wallets works fine
  • Copied the added address from the above setup
  • Upgraded to 1.36.106 nightly build
  • Verified a new option for Deprecated (Not recommended) option is shown
  • Verified searching for the address from step 3 lists the accounts when Deprecated (Not recommended) option is selected
1.32.106 Install
Search on Live
Search on Legacy
Search on Deprecated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants