Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

save password prompt using Chrome's UI #12398

Closed
kjozwiak opened this issue Oct 29, 2020 · 2 comments · Fixed by brave/brave-core#6989
Closed

save password prompt using Chrome's UI #12398

kjozwiak opened this issue Oct 29, 2020 · 2 comments · Fixed by brave/brave-core#6989
Assignees
@mkarolin
Labels
design A design change, especially one which needs input from the design team feature/password-manager OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.17.x - Release #1

Comments

@kjozwiak
Copy link
Member

Description

Looks like the fix from #10008 regressed on C87 again. We'll need to remove the Chrome UI from the Save Password prompt/modal.

Steps to Reproduce

  1. launch brave with C87 and load a website with login/credentials
  2. login and you'll notice that we're displaying Chrome's UI

Actual result:

Screen Shot 2020-10-29 at 1 49 01 PM

Expected result:

Screen Shot 2020-10-29 at 3 57 54 PM

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave | 1.18.18 Chromium: 87.0.4280.27 (Official Build) nightly (x86_64)
-- | --
Revision | d8c1fe98de8d9c6bd46ebe8b0cc9d2b6bdccca1e-refs/branch-heads/4280@{#556}
OS | macOS Version 10.15.7 (Build 19H2)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No, specific to CR87
  • Can you reproduce this issue with the beta channel? No, specific to CR87
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @rebron @mkarolin
@kjozwiak kjozwiak added design A design change, especially one which needs input from the design team feature/password-manager QA/Yes release-notes/exclude OS/Desktop labels Oct 29, 2020
@mkarolin mkarolin mentioned this issue Oct 29, 2020
Merged
32 tasks
@mkarolin mkarolin self-assigned this Oct 29, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Oct 30, 2020
@mkarolin
Fixes save password prompt.
691f86a 
Fixes brave/brave-browser#12398

Image files we were overriding got renamed.

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/39eded942d854f367be5bde332189a6a8271c76f

commit 39eded942d854f367be5bde332189a6a8271c76f
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date:   Tue Sep 22 17:27:02 2020 +0000

    [Passwords] Update header image for different states in Save Bubble

    As per the attached bug, here is the logic for changing the header image

    - The illustration should change when the user switches between "Save to device" and "Sav  to account".
    - In the Update bubble, the illustration should change based on where the update will go.
    - If the update will go to both locations, use the "account" image.

    Screencast:
    Light mode: https://screencast.googleplex.com/cast/NjQxNjYzNjU3MzY0Njg0OHw0NTg2MTgzYy1kMw
    Dark mode: https://screencast.googleplex.com/cast/NTY4MTQ3NTYxMTUyNTEyMHwzOTI4Y2JkYy1mZQ

    Bug: 1115936
@mkarolin mkarolin mentioned this issue Oct 30, 2020
Merged
33 tasks
@GeetaSarvadnya
Copy link

Reproduced in Windows 10 x64 - Version 1.18.18 Chromium: 87.0.4280.27

image

@mkarolin mkarolin added this to the 1.18.x - Nightly milestone Oct 30, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Nov 9, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.17.63 Chromium: 87.0.4280.49 (Official Build) unknown (x86_64)
-- | --
Revision | f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS | macOS Version 10.14.6 (Build 18G6032)

Verified STR from description

Screen Shot 2020-11-09 at 6 03 09 AM

Verified passed with

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Windows 7 Service Pack 1 (Build 7601.24544)

Verified STR from description

image

Verification passed on

Brave 1.17.63 Chromium: 87.0.4280.49 (Official Build) dev (64-bit)
Revision f77f85899646b42a1d3c8ff36794e00becab9171-refs/branch-heads/4280@{#1115}
OS Ubuntu 18.04 LTS

Verified STR from description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
design A design change, especially one which needs input from the design team feature/password-manager OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.17.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes save password prompt. brave/brave-core
5 participants
@kjozwiak @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin