Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent auto downloading & opening a PDF file on click #12902

Closed
chkk525 opened this issue Nov 26, 2020 · 2 comments · Fixed by brave/brave-core#7279
Closed

Prevent auto downloading & opening a PDF file on click #12902

chkk525 opened this issue Nov 26, 2020 · 2 comments · Fixed by brave/brave-core#7279

Comments

@chkk525
Copy link

chkk525 commented Nov 26, 2020

Description

  • Currently, when a user clicks a link to a PDF file, it'll be downloaded and opened in an associated app without confirming.
  • For security reasons, some users want to prevent it

Steps to reproduce

  1. On Android, click https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf

Actual result

It'll be downloaded and opened in a default PDF viewer app.

Expected result

  • Allow them to prevent it as an option menu

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik
Copy link
Contributor

samartnik commented Jan 6, 2021

Test plan 1:

  1. Without changing anything, click https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf
  2. Pdf should be opened automatically (same behavior as before)

Test plan 2:

  1. Go to Downloads settings
  2. Turn off Automatically open when possible
  3. Click https://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf
  4. Pdf file should be just downloaded, without opening

@srirambv
Copy link
Contributor

srirambv commented Jan 6, 2021

Verification passed on OnePlus 6T with Android 10 running 1.19.74 x64 build


Verification passed on Samsung Tab A with Android 10 running 1.19.74 x64 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants