Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons for macOS #13005

Closed
rebron opened this issue Dec 2, 2020 · 11 comments · Fixed by brave/brave-core#7356
Closed

Update icons for macOS #13005

rebron opened this issue Dec 2, 2020 · 11 comments · Fixed by brave/brave-core#7356
Assignees
Labels
design A design change, especially one which needs input from the design team OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include

Comments

@rebron
Copy link
Collaborator

rebron commented Dec 2, 2020

Description

Update icons for macOS Big Sur similar to iOS/rounded square icons to be consistent with other apps on macOS

Actual result:

88846180-dcf65c80-d1aa-11ea-901b-67a113d40a5a

Expected result:

Icons should be a little larger than the previous round and have a white background.

Screen Shot 2020-12-04 at 11 37 32 AM

Iconsets: In gdrive

Reproduces how often:

n/a

Brave version (brave://version info)

Target for 1.19.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

First try with #11002 but icons came out to small. Using this issue as follow-up.

@rebron rebron added design A design change, especially one which needs input from the design team OS/macOS QA/Yes release-notes/include OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 2, 2020
@simonhong
Copy link
Member

simonhong commented Dec 3, 2020

It would be good to have new icon for development build (grayed one) also.

@karenkliu
Copy link

@simonhong Designs added! I included the development build too.

simonhong added a commit to brave/brave-core that referenced this issue Dec 6, 2020
@simonhong simonhong added this to the 1.20.x - Nightly milestone Dec 9, 2020
@stephendonner
Copy link

stephendonner commented Jan 25, 2021

This is looking good on macOS Big Sur (11.1 (20C69)), for the following icons:

  • Brave Beta
Brave 1.20.85 Chromium: 88.0.4324.96 (Official Build) beta (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 11.1 (Build 20C69)
  • Brave Dev
Brave 1.20.88 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 11.1 (Build 20C69)
  • Brave Nightly
Brave 1.20.90 Chromium: 88.0.4324.96 (Official Build) dev (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 11.1 (Build 20C69)

Still pending:

  • Looks like we'll need a Release Preview/Release Candidate to verify on the Release channel
  • Also need someone with a (self-built?) developer binary to show theirs, using Big Sur
  • Probably a good idea for someone with Catalina to post theirs, as they shouldn't have changed there

Screen Shot 2021-01-26 at 9 06 00 AM

@LaurenWags
Copy link
Member

@stephendonner your Brave Nightly is old (1.19.x) - best to try on the latest Nightly from https://github.com/brave/brave-browser/releases.

I noticed because your Nightly icon has a dark background whereas mine does not - and per the description each icon should have a white background. So, please give it another check on a updated Nightly. If you continue to have a dark background on your icon we'll want to follow up on that.

@LaurenWags
Copy link
Member

LaurenWags commented Feb 4, 2021

Verified passed with the following versions using macOS x64 Catalina:

Brave | 1.20.100 Chromium: 88.0.4324.146 (Official Build) (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)
Brave | 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)
Brave | 1.21.45 Chromium: 88.0.4324.146 (Official Build) dev (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)
Brave | 1.22.2 Chromium: 88.0.4324.146 (Official Build) nightly (x86_64)
-- | --
Revision | 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS | macOS Version 10.15.7 (Build 19H15)

Screen Shot 2021-02-04 at 4 56 38 PM


Verified passed with the following versions using macOS arm64 Big Sur:

Brave	1.20.100 Chromium: 88.0.4324.146 (Official Build) (arm64)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	macOS Version 11.2 (Build 20D64)
Brave	1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (arm64)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	macOS Version 11.2 (Build 20D64)
Brave	1.21.45 Chromium: 88.0.4324.146 (Official Build) dev (arm64)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	macOS Version 11.2 (Build 20D64)
Brave	1.22.2 Chromium: 88.0.4324.146 (Official Build) nightly (arm64)
Revision	406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS	macOS Version 11.2 (Build 20D64)

Screen Shot 2021-02-04 at 5 12 34 PM


Development build icon was confirmed for QA by @darkdh and @iefremov:

Screen Shot 2021-02-04 at 14 56 02

@thaliaarchi
Copy link

I appreciate that this follows the design changes introduced by Chrome, but is there a flag to disable this? It is incongruous with the other icons in my dock and the white space bugs me. There are many common non-square icons: Firefox, VS Code, Messages, and many non-aligned icons including Mail, Notes, and Pages.

@zevrix
Copy link

zevrix commented Feb 24, 2021

Please give us an option to restore the original icon.

Brave's original icon is a masterpiece. There's no need to change anything. The new icon just looks as a mistake.

If you really just have to follow this shape while keeping an impressive icon, then this would be much better:

brave-icon

@tre-dev
Copy link

tre-dev commented Mar 2, 2021

I guess the look depends on the taste of the individual user, the icons next to it and possibly also the alignment of the dock. For me, the new version doesn't fit at all, it looks rather ugly tbh :/

image

@zevrix
Copy link

zevrix commented Mar 2, 2021

For me, the new version doesn't fit at all, it looks rather ugly tbh :/

Absolutely. I love Brave but If they keep this icon, they also should change the name from "Brave" to "Caged & Conquered".

@bsclifton
Copy link
Member

cc: @bradleyrichter @karenkliu

@aparkerdavid
Copy link

Aesthetic debates over the squircle aside, this icon isn't quite right. It's a little too large, and the drop shadow is a little too deep. See:
Screen Shot 2021-03-13 at 1 29 03 PM
Apple publishes a template for Big-Sur-style icons, it should be possible to just drop in the Brave logo and get a pixel-perfect result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-macOS-arm64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants