-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icons for macOS #13005
Comments
It would be good to have new icon for development build (grayed one) also. |
@simonhong Designs added! I included the development build too. |
This is looking good on macOS Big Sur (11.1 (20C69)), for the following icons:
Still pending:
|
@stephendonner your Brave Nightly is old (1.19.x) - best to try on the latest Nightly from https://github.com/brave/brave-browser/releases. I noticed because your Nightly icon has a dark background whereas mine does not - and per the description each icon should have a white background. So, please give it another check on a updated Nightly. If you continue to have a dark background on your icon we'll want to follow up on that. |
Verified passed with the following versions using
Verified passed with the following versions using
Development build icon was confirmed for QA by @darkdh and @iefremov: |
I appreciate that this follows the design changes introduced by Chrome, but is there a flag to disable this? It is incongruous with the other icons in my dock and the white space bugs me. There are many common non-square icons: Firefox, VS Code, Messages, and many non-aligned icons including Mail, Notes, and Pages. |
Absolutely. I love Brave but If they keep this icon, they also should change the name from "Brave" to "Caged & Conquered". |
Description
Update icons for macOS Big Sur similar to iOS/rounded square icons to be consistent with other apps on macOS
Actual result:
Expected result:
Icons should be a little larger than the previous round and have a white background.
Iconsets: In gdrive
Reproduces how often:
n/a
Brave version (brave://version info)
Target for 1.19.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
First try with #11002 but icons came out to small. Using this issue as follow-up.
The text was updated successfully, but these errors were encountered: