Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] "Welcome to Brave Rewards" / ETA UI not shown on second app launch #13195

Closed
LaurenWags opened this issue Dec 14, 2020 · 3 comments · Fixed by brave/brave-core#7447
Closed

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 14, 2020

Description

After you start using Brave Rewards when you launch the app a second time and open the panel, you should see the "Welcome to Brave Rewards" UI with a message indicating the ETA of your first Ads payment. This UI is not showing.

See figma doc: https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=1555%3A0

Steps to reproduce

  1. Clean install
  2. Open panel, tap "Start using Brave Rewards"
  3. Skip to end of onboarding tour, tap done
  4. See below UI.
  5. Don't "x" out of this.
  6. Close panel.
  7. Remove app from background memory.
  8. Relaunch app.
  9. Tap on panel.
    --> do not see below UI as I was expecting per figma

Actual result

Normal panel is shown

Expected result

Screen Shot 2020-12-14 at 5 43 30 PM

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? n/a
  • Can you reproduce this issue with the current Play Store Beta version? yes 1.18.x
  • Can you reproduce this issue with the current Play Store Nightly version? yes 1.20.28

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.18.72

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @codybanxs @deeppandya @brave/legacy_qa

@LaurenWags
Copy link
Member Author

This functionality was working in 1.20.23 Nightly and no longer works in 1.20.28 Nightly cc @deeppandya

@kjozwiak
Copy link
Member

Closing as brave/brave-core#7447 was merged into 1.18.x via brave/brave-core#7438.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 16, 2020

Verification passed on Samsung Galaxy J3 version 5.1.1 running Bravearm 1.18.73

  • Verified the STR from the description
    image

Verification passed on Brave v1.18.73 on Samsung Galaxy Tab S5e (Android 9.0)

  • Verified the STR from the description
    Screenshot_20201216-133301_Brave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants