Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement earn&give onboarding #12141

Closed
NejcZdovc opened this issue Oct 14, 2020 · 2 comments · Fixed by brave/brave-core#7112
Closed

[Android] Implement earn&give onboarding #12141

NejcZdovc opened this issue Oct 14, 2020 · 2 comments · Fixed by brave/brave-core#7112
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.18.x - Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Oct 14, 2020 •
edited
Loading

Desktop UI for the panel as a reference https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=11%3A1
@NejcZdovc NejcZdovc added feature/rewards OS/Android Fixes related to Android browser functionality labels Oct 14, 2020
@NejcZdovc NejcZdovc mentioned this issue Oct 14, 2020
Closed
15 tasks
@NejcZdovc
Copy link
Contributor Author

cc @jamesmudgett

@deeppandya deeppandya mentioned this issue Nov 10, 2020
Merged
33 tasks
@NejcZdovc NejcZdovc added this to the 1.18.x - Nightly milestone Nov 11, 2020
@LaurenWags LaurenWags mentioned this issue Dec 11, 2020
Closed
7 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Dec 14, 2020 •
edited by btlechowski
Loading

Verification passed on LG Nexus 5 with Android 5.1 running 1.18.72 Bravearm.apk

Using https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=1555%3A0 for verification.

Entry Points - Rewards Panel - New User
Confirmed new user gets large onboarding UI when tapping on the panel Confirmed clicking the "x" closes large onboarding UI and shows small onboarding UI: Confirmed clicking on the "x" closes small onboarding UI and shows normal panel:
Screenshot_2020-12-14-16-21-52 Screenshot_2020-12-14-16-22-39 Screenshot_2020-12-14-16-23-01

Confirmed "Terms of Service" link opens TOS.
Confirmed "Privacy Policy" link opens Privacy Policy.

Confirmed "Take a quick tour" opens onboarding tour (no settings slide) and does not enable Ads and AC.

Confirmed "Start using Brave Rewards" opens onboarding tour (with settings slide) and also enables Ads and AC.

Entry Points - Rewards Settings - New User

Confirmed new user gets large onboarding UI when navigating to chrome://rewards: 


Screenshot_2020-12-14-16-45-26

Confirmed clicking the "x" closes large onboarding UI and does not enable Ads/AC.
Confirmed "Terms of Service" link opens TOS.
Confirmed "Privacy Policy" link opens Privacy Policy.

Confirmed "Take a quick tour" opens onboarding tour via panel (no settings slide) and does not enable Ads and AC.

Confirmed "Start using Brave Rewards" does not open onboarding tour but enables Ads and AC.

Onboarding Sequence - First app open - New User (small onboarding UI)
Confirmed new user gets large onboarding UI when tapping on the panel Confirmed clicking the "x" closes large onboarding UI and shows small onboarding UI: Confirmed clicking on the "x" closes small onboarding UI and shows normal panel:
Screenshot_2020-12-14-16-59-04 Screenshot_2020-12-14-16-59-10 Screenshot_2020-12-14-17-03-03

Confirmed "Terms of Service" link opens TOS.
Confirmed "Privacy Policy" link opens Privacy Policy.

Confirmed "Quick tour" opens onboarding tour (no settings slide) and does not enable Ads and AC.

Confirmed "I'm in!" enables Ads and AC. Confirmed chrome://rewards opens in the tab.

Onboarding Sequence - First app open - New User (Quick tour onboarding)

When on the Onboarding UI, tapped on "Take a quick tour":

Onboarding 1 2 3 4 5 6 7 8
Screenshot_2020-12-14-16-59-04 Screenshot_2020-12-14-17-13-04 Screenshot_2020-12-14-17-13-12 Screenshot_2020-12-14-17-13-31 Screenshot_2020-12-14-17-13-40 Screenshot_2020-12-14-17-13-51 Screenshot_2020-12-14-17-13-59 Screenshot_2020-12-14-17-14-05 Screenshot_2020-12-14-17-14-11

Confirmed all items on the small onboarding UI worked as expected after completing the quick onboarding tour.

Onboarding Sequence - First app open - New User (Opt-in onboarding)

When on the Onboarding UI, tapped on "Start using Brave Rewards":

Onboarding 1 2 3 4 5 6 7 8 9
Screenshot_2020-12-14-17-31-16 Screenshot_2020-12-14-17-31-41 Screenshot_2020-12-14-17-31-50 Screenshot_2020-12-14-17-32-00 Screenshot_2020-12-14-17-32-08 Screenshot_2020-12-14-17-32-13 Screenshot_2020-12-14-17-32-29 Screenshot_2020-12-14-17-32-36 Screenshot_2020-12-14-17-32-54 Screenshot_2020-12-14-17-33-03

Confirmed Ads and AC were enabled on chrome://rewards.

Onboarding Sequence - On next app and panel opening - New User (did not opt-in previous session)

Verified small onboarding UI shows in the following scenario:

  1. Clean install 1.18.x
  2. Tap on BAT logo, see large onboarding UI.
  3. Close panel and go about browsing.
  4. Remove app from memory.
  5. Relaunch Brave.
  6. Tap on BAT logo.
  7. See small onboarding UI as expected.

Screenshot_2020-12-14-17-40-45

Onboarding Sequence - On next app and panel opening - New User (did opt-in previous session)

Verified Welcome to Brave Rewards UI shows in the following scenario:

  1. Clean install 1.18.x
  2. Tap on BAT logo, see large onboarding UI.
  3. Tap on "Start using Brave Rewards". Complete tour or skip to the end and tap "Done".
  4. Remove app from memory.
  5. Relaunch Brave.
  6. Tap on BAT logo.
    --> Do not see Welcome to Brave Rewards UI as expected.

Logged #13195

Day 4 - Forced Rewards Onboarding - New User

Scenario 1:

  1. Clean profile 1.18.x. Do not tap on BAT logo.
  2. Close app, remove from memory. Advance Date/Time 24h.
  3. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  4. Close app, remove from memory. Advance Date/Time 24h.
  5. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  6. Close app, remove from memory. Advance Date/Time 24h.
  7. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  8. Close app, remove from memory. Advance Date/Time 24h.
  9. Launch.
  10. Confirmed panel opens automatically and shows large onboarding UI.

Scenario 2:

  1. Clean profile 1.18.x. Tap on BAT logo. Dismiss large and small onboarding.
  2. Close app, remove from memory. Advance Date/Time 4 days.
  3. Launch.
  4. Confirmed panel does not open automatically as the user has already interacted with it.

cc @kjozwiak for the following scenarios:

  • Entry Points - NTP SI - New User
  • Entry Points - NTP SI - Existing User Ads ON
  • Onboarding Sequence - First SI Image - New User
  • Day 4 - Forced Rewards onboarding from NTP SI perspective

Verification PASSED on Samsung Galaxy S10+ running Android 10 using 1.18.72 CR: 87.0.4280.101

Entry Points - New User - NTP SI

Entry Points - Existing User, Ads on - NTP SI
  • ensured that dismissing the the NTP SI rewards modal via X closes the modal without any issues
  • ensured that the NTP SI modal expands/displays the correct information if ads have already been enabled
  • ensured that tapping on Learn more about sponsored images opens a new tab with brave.com/faq-rewards
  • ensured that tapping on Hide sponsored images disabled NTP SI and they stop appearing when opening NTP

Onboarding Sequence - New User - First SI Image
  • ensured that tapping on Terms of Services & Privacy Policy via the rewards panel doesn't dismiss onboarding
  • ensured that tapping on Start using Brave Rewards starts the onboarding process
    • ensure that you can navigate through the onboarding experience using either of the following:
      • < GO BACK, NEXT > or swiping side to side
    • ensured tapping on Done completes the onboarding flow
    • ensured that Skip takes you to the last page/panel (Wooohoooo) without any issues
    • ensured that tapping on X closes onboarding
  • ensured that tapping on Take a quick tour starts the rewards tour (same as onboarding without ads/a-c opt-in)
    • ensure that you can navigate through the onboarding experience using either of the following:
      • < GO BACK, NEXT > or swiping side to side
    • ensured tapping on Done completes the tour
    • ensured that Skip takes you to the last page/panel (Wooohoooo) without any issues
    • ensured that tapping on X closes onboarding
Example Example
Screenshot_20201211-012654_Brave - Nightly Screenshot_20201211-011703_Brave - Nightly
Day 4 - Forced Rewards Onboarding

Verified the Day 4 - Forced Rewards Onboarding scenario via #13160 (comment)

Verification passed on Brave v1.18.72 on Samsung Galaxy Tab S5e (Android 9.0)

Using https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=1555%3A0 for verification.

Entry Points - Rewards Panel - New User
Confirmed new user gets large onboarding UI when tapping on the panel Confirmed clicking the "x" closes large onboarding UI and shows small onboarding UI: Confirmed clicking on the "x" closes small onboarding UI and shows normal panel:
Screenshot_20201215-120547_Brave Screenshot_20201215-120631_Brave Screenshot_20201215-120708_Brave

Confirmed "Terms of Service" link opens TOS.
Confirmed "Privacy Policy" link opens Privacy Policy.

Confirmed "Take a quick tour" opens onboarding tour (no settings slide) and does not enable Ads and AC.

Confirmed "Start using Brave Rewards" opens onboarding tour (with settings slide) and also enables Ads and AC.

Entry Points - Rewards Settings - New User

Confirmed new user gets large onboarding UI when navigating to chrome://rewards: 


Screenshot_20201215-130732_Brave

Confirmed clicking the "x" closes large onboarding UI and does not enable Ads/AC.
Confirmed "Terms of Service" link opens TOS.
Confirmed "Privacy Policy" link opens Privacy Policy.

Confirmed "Take a quick tour" opens onboarding tour via panel (no settings slide) and does not enable Ads and AC.

Confirmed "Start using Brave Rewards" does not open onboarding tour but enables Ads and AC.

Onboarding Sequence - First app open - New User (small onboarding UI)
Confirmed new user gets large onboarding UI when tapping on the panel Confirmed clicking the "x" closes large onboarding UI and shows small onboarding UI: Confirmed clicking on the "x" closes small onboarding UI and shows normal panel:
Screenshot_20201215-120547_Brave Screenshot_20201215-120631_Brave Screenshot_20201215-120708_Brave

Confirmed "Terms of Service" link opens TOS.
Confirmed "Privacy Policy" link opens Privacy Policy.

Confirmed "Quick tour" opens onboarding tour (no settings slide) and does not enable Ads and AC.

Confirmed "I'm in!" enables Ads and AC. Confirmed chrome://rewards opens in the tab.

Onboarding Sequence - First app open - New User (Quick tour onboarding)

When on the Onboarding UI, tapped on "Take a quick tour":

Onboarding 1 2 3 4 5 6 7 8
Screenshot_20201215-131848_Brave Screenshot_20201215-131857_Brave Screenshot_20201215-131904_Brave Screenshot_20201215-131913_Brave Screenshot_20201215-131919_Brave Screenshot_20201215-131924_Brave Screenshot_20201215-131943_Brave Screenshot_20201215-131948_Brave Screenshot_20201215-131954_Brave

Confirmed all items on the small onboarding UI worked as expected after completing the quick onboarding tour.

Onboarding Sequence - First app open - New User (Opt-in onboarding)

When on the Onboarding UI, tapped on "Start using Brave Rewards":

Onboarding 1 2 3 4 5 6 7 8 9
Screenshot_20201215-133112_Brave Screenshot_20201215-133117_Brave Screenshot_20201215-133129_Brave Screenshot_20201215-133135_Brave Screenshot_20201215-133140_Brave Screenshot_20201215-133145_Brave Screenshot_20201215-133150_Brave Screenshot_20201215-133154_Brave Screenshot_20201215-133159_Brave Screenshot_20201215-133205_Brave

Confirmed Ads and AC were enabled on chrome://rewards.

Onboarding Sequence - On next app and panel opening - New User (did not opt-in previous session)

Screenshot_20201215-134346_Brave

Onboarding Sequence - On next app and panel opening - New User (did opt-in previous session)

Encountered #13195

Day 4 - Forced Rewards Onboarding - New User

Scenario 1:

  1. Clean profile 1.18.x. Do not tap on BAT logo.
  2. Close app, remove from memory. Advance Date/Time 24h.
  3. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  4. Close app, remove from memory. Advance Date/Time 24h.
  5. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  6. Close app, remove from memory. Advance Date/Time 24h.
  7. Launch, do not tap on BAT logo. Observe panel does not open automatically.
  8. Close app, remove from memory. Advance Date/Time 24h.
  9. Launch.
  10. Confirmed panel opens automatically and shows large onboarding UI.

Scenario 2:

  1. Clean profile 1.18.x. Tap on BAT logo. Dismiss large and small onboarding.
  2. Close app, remove from memory. Advance Date/Time 4 days.
  3. Launch.
  4. Confirmed panel does not open automatically as the user has already interacted with it.

@LaurenWags LaurenWags mentioned this issue Dec 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.18.x - Release
Development

Successfully merging a pull request may close this issue.

New rewards onboarding android brave/brave-core
5 participants
@kjozwiak @deeppandya @NejcZdovc @LaurenWags @btlechowski