New rewards onboarding android #7112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-linux
CI/skip-macos-x64
deeppandya
commented
Nov 10, 2020
| } | ||
| mRewardsPopup = new BraveRewardsPanelPopup(v); | ||
| mRewardsPopup.showLikePopDownMenu(); | ||
| // Context context = getContext(); |
There was a problem hiding this comment.
@SergeyZhukovsky i was not about recently updated onboarding so i have asked for the confirmation. so till then i have commented out below block.,
Update existing UI
Add scrollview for brave rewards onboarding
deeppandya
force-pushed
the
new_rewards_onboarding_android
branch
from
5e44ea9 to
87fd8f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#12141
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.