Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix shields settings migration #13522

Closed
samartnik opened this issue Jan 12, 2021 · 1 comment · Fixed by brave/brave-core#7575
Closed

[Android] Fix shields settings migration #13522

samartnik opened this issue Jan 12, 2021 · 1 comment · Fixed by brave/brave-core#7575
Assignees
Labels
OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude

Comments

@samartnik
Copy link
Contributor

samartnik commented Jan 12, 2021

Description

Migration doesn't work for Android.

Steps to reproduce

  1. Install current version from Play Store
  2. Change shields settings for any web site
  3. Upgrade to the latest nightly version
  4. Settings for that web site were reset

Actual result

Settings for web site are reset

Expected result

Settings for web site are preserved

Issue reproduces how often

Always

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.20.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.19.84 x64 build

  • Verified changing site shields setting in older version and upgrading to 1.19.84 retains the site-specific settings

Verification passed on Samsung Tab A with Android 10 running 1.19.84 x64 build

  • Verified changing site shields setting in older version and upgrading to 1.19.84 retains the site-specific settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass - Android ARM QA Pass - Android Tab QA/Test-Plan-Specified QA/Yes release/blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants