Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 88.0.4324.51 to Chromium 88.0.4324.79. #13427

Closed
mkarolin opened this issue Jan 7, 2021 · 5 comments · Fixed by brave/brave-core#7544 or #13429
Closed

Upgrade from Chromium 88.0.4324.51 to Chromium 88.0.4324.79. #13427

mkarolin opened this issue Jan 7, 2021 · 5 comments · Fixed by brave/brave-core#7544 or #13429

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Jan 7, 2021

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/88.0.4324.51..88.0.4324.79?pretty=fuller&n=10000

QA tests:

Can be tested together with #13103

Check branding items
Check for version bump

No specific code changes in Brave (only line number changes in patches).

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 11, 2021

Verification passed on


Brave | 1.20.71 Chromium: 88.0.4324.79 (Official Build) nightly (64-bit)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | Windows 10 OS Version 2004 (Build 19041.685)

1. Shields Settings

Clean profile

  • Verified default global shield settings applied across all the opened site
  • Verified changed Trackers & ads blocking global shield settings are applied across all the opened site
  • Verified changed Cookies blocking global shield settings are applied across all the opened site
  • Verified changed Fingerprinting blocking global shield settings are applied across all the opened site
  • Verified that global shield settings retained in all the opened site after the browser restart
  • Verified that changes done in the site shield settings are propagated to PT
  • Verified that changes done in the site shield settings in PT are not propagated to Normal tab

Upgraded profile

  • Installed 1.18.x nightly and opened few sites and upgraded profile to 1.20.x and ensured default global shield settings retained across all the opened site after the upgrade
  • Installed 1.18.x nightly and opened few sites and changed global shield settings and upgraded profile to 1.20.x and ensured global shield settings retained across all the opened sites after upgrade
  • Verified that global shield settings retained in all the opened site after the browser restart

2. Verified 2, 3 and 4 sections from #13103 (comment) and ensured functionality is working as expected

3. Encountered issues below
#13271
#13391
#12781
#13137

@kjozwiak
Copy link
Member

Awesome job @GeetaSarvadnya 👍

@btlechowski
Copy link

Verification passed on

Brave 1.19.82 Chromium: 88.0.4324.79 (Official Build) dev (64-bit)
Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS Ubuntu 18.04 LTS

Verified test plan from #13103 (comment)

image

Verified Shields Settings

  • upgrade scenario: retains settings
  • proper functionality according to settings

Verified Buttons functions properly:

  • Rewards icon in the location bar
  • Onion location button
  • Translate bubble buttons
  • Ad notifications buttons

Verified Creation of new profiles

  • Flow
  • Avatars look correctly

Verified WebUI pages look correct (have Brave theme)

  • Note: Printing section was removed from Settings

Verified New tab button functions correctly

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.19.83 x64 build

OnePlus 6T (Android 10) Samsung Tab A (Android 10)

@kjozwiak
Copy link
Member

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (x86_64)
--- | ---
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | macOS Version 11.1 (Build 20C69)

Buttons functionality

Bookmark Button/Speedreader

Google Translate Extension

  • visited https://allegro.pl/ and ensured that the translation icon appeared via the omnibox
    • ensured that clicking it correctly opened the Google Translation modal so you could install the extension
    • ensured that both Install & Cancel works as expected
    • ensured that Don't ask me again" worked as expected works as expected
    • ensured that Offer to translate pages that aren't in a language you read works as expected when Don't ask me again" worked as expected is selected

Open in Tor

Rewards

  • ensured that clicking on rewards panel worked as expected
  • ensured you could interact with the panel without any issues
    • Reward Settings, setting monthly contributions, tipping, accepting UGP grant

Avatar/Profiles

  • ensured that you can create a new profile without any issues
  • ensured that you can use previosuly created profiles without any issues
  • ensured that the avatars looked correct when creating a new profile
  • ensured that you can remove profiles

Shields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment