Follow up of #5720 - favicon for verified vimeo publisher is incorrect in auto-contribution table

[GeetaSarvadnya]

Description

Follow up of #5720 - favicon for verified vimeo publisher is incorrect

Steps to Reproduce

1. Follow the steps/STR from favicon for verified vimeo publisher is incorrect #5720

Actual result:

AC table - Vimeo pubs are not gettig added just domain is getting added into AC table

Tipping Banner - There is no publisher favicon

Monthly tips: Generic Vimeo favicon is shown instead of pubs favicon

One time tips: Generic Vimeo favicon is shown instead of pubs favicon

Expected result:

Correct vimeo favicon on panel, ac, and tips tables.

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.18.57 Chromium: 87.0.4280.66 (Official Build) beta (64-bit)
Revision	fd98a29dd59b36f71e4741332c9ad5bda42094bf-refs/branch-heads/4280@{#1432}
OS	Windows 10 OS Version 2004 (Build 19041.572)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @emerick @rebron

[GeetaSarvadnya]

@emerick Do I need to install the Vimeo GS script (brave/brave-core#6955) in order to test issue #5720 in Beta channel 1.18.57? Please let me know.

[emerick]

@GeetaSarvadnya No, you just have to verify in brave://components that you have the latest version of the Brave Local Data Updater (it should be 1.0.38 currently).

[LaurenWags]

Reproduced on macOS

Brave | 1.18.62 Chromium: 87.0.4280.67 (Official Build) dev (x86_64)
-- | --
Revision | 0e5d92df40086cf0050c00f87b11da1b14580930-refs/branch-heads/4280@{#1441}
OS | macOS Version 10.14.6 (Build 18G6042)

Brave Local Data Updater component version is 1.0.38 as per #12781 (comment)

Using Staging env, visited vimeo.com/bravelaurenwags
Opened the panel and saw generic vimeo favicon even though I have a custom one set on the publishers site for myself:

[emerick]

Good find, it's due to this line in the Vimeo script:

https://github.com/brave/brave-site-specific-scripts/blob/1308b083ea7565693ca3655d02950e62614f3e7e/scripts/brave_rewards/publisher/vimeo/publisherInfo.ts#L126

Should be set via something like this instead, I think:

favIconUrl: utils.buildFavIconUrl(userId)

[LaurenWags]

Verified passed with

Brave	1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	macOS Version 10.15.7 (Build 19H15)

Used dev component version 1.0.40:

Note - per #12968 (comment), Vimeo will only be added to AC table with 1.19.x, this is why this issue was tested with dev 1.19.x listed above and not release 1.18.x.

Using Staging env and vimeo.com/bravelaurenwags (verified creator), confirmed expected (custom) favicon:

Panel	One-Time Tip	Monthly Tip	AC

Using Production env and vimeo.com/willchristiansen (verified creator), confirmed expected (custom) favicon:

Panel	Monthly Tip	AC

Using Production env and https://vimeo.com/jonathangurvit (verified creator), confirmed expected (Vimeo) favicon:

Panel	Monthly Tip	AC

Using Production env and https://vimeo.com/ponysmasher (not verified creator), confirmed expected (generic Vimeo) favicon:

Panel	Monthly Tip	AC

---

Verified passed with

Brave	1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision	9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS	Linux

Used dev component version 1.0.40:

Note - per #12968 (comment), Vimeo will only be added to AC table with 1.19.x, this is why this issue was tested with dev 1.19.x listed above and not release 1.18.x.

Also, on Linux and Windows, sometimes multiple restarts are required to get Vimeo to be shown in AC list - #13391 (comment)

Using Staging env and vimeo.com/bravelaurenwags (verified creator), confirmed expected (custom) favicon:

Panel	One-Time Tip	Monthly Tip	AC

Using Production env and vimeo.com/willchristiansen (verified creator), confirmed expected (custom) favicon:

Panel	One-Time Tip	Monthly Tip	AC

---

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.685)

Used the following dev component using --use-dev-goupdater-url:

Using staging env and https://vimeo.com/bravelaurenwags (verified creator), confirmed expected (custom) favicon:

Panel	Banner	One-Time Tip	Monthly Tip	AC

Using production env and https://vimeo.com/pakocampo (verified creator), confirmed expected (custom) favicon:

Panel	Banner	One-Time Tip	Monthly Tip	AC

Using production env and https://vimeo.com/christxstar (verified creator), confirmed expected (Vimeo) favicon:

Panel	Banner	One-Time Tip	Monthly Tip	AC

Using production env and https://vimeo.com/jordanmanley (not verified creator), confirmed expected (generic Vimeo) favicon:

Panel	Banner	One-Time Tip	Monthly Tip	AC

---

Verification PASSED on Mint 19.1 x64 using the following build:

Brave | 1.19.76 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
--- | ---
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Linux

Used the following dev component using --use-dev-goupdater-url:

Using production env and https://vimeo.com/ryanlightbourn (verified creator), confirmed expected (Vimeo) favicon:

Panel	Banner	One-Time Tip	Monthly Tip	AC

Using production env and https://vimeo.com/lokan (verified creator), confirmed expected (custom) favicon:

Panel	Banner	One-Time Tip	Monthly Tip	AC