Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cr88 followup: Brave toolbar buttons (Bookmark, Speedreader) don't work. #13203

Closed
mkarolin opened this issue Dec 15, 2020 · 1 comment · Fixed by brave/brave-core#7440
Closed

cr88 followup: Brave toolbar buttons (Bookmark, Speedreader) don't work. #13203

mkarolin opened this issue Dec 15, 2020 · 1 comment · Fixed by brave/brave-core#7440
Assignees
@mkarolin
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Milestone
1.19.x - Release

Comments

@mkarolin
Copy link
Contributor

STR:

  1. Start Brave Nightly (1.20.XX).
  2. Navigate to a site (e.g. cnn.com)
  3. Click Bookmark button on the toolbar

Expected result:
Bookmark bubble shows

Actual result:
Nothing happens.

Same with the speed reader button.
@mkarolin mkarolin self-assigned this Dec 15, 2020
@mkarolin mkarolin mentioned this issue Dec 15, 2020
Merged
33 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Dec 15, 2020
@mkarolin
Fixes Bookmark & Speedreader buttons.
6f0210d 
The buttons became unresponsive due to cr88 bump change made in
aa3b104

Fixes brave/brave-browser#13203
@mkarolin mkarolin mentioned this issue Dec 15, 2020
Merged
23 tasks
@mkarolin mkarolin added this to the 1.20.x - Nightly milestone Dec 15, 2020
@LaurenWags LaurenWags mentioned this issue Dec 17, 2020
Closed
@mkarolin mkarolin mentioned this issue Jan 4, 2021
Merged
23 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jan 14, 2021 •
edited by btlechowski
Loading

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (x86_64)
--- | ---
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | macOS Version 11.1 (Build 20C69)

Bookmarks via Toolbar

Bookmark Toolbar URL Bookmark Modal
Screen Shot 2021-01-14 at 12 33 18 AM Screen Shot 2021-01-14 at 12 33 34 AM

Speedreader via Toolbar

  • enabled speedreader via brave://flags/#brave-speedreader
  • ensured that clicking on it enabled the feature without any issues
  • visited https://www.bloomberg.com and selected an article
  • ensured that the article was loaded in reader mode

Example:

Screen Shot 2021-01-14 at 12 41 01 AM

Verification passed on

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Bookmarks via Toolbar

Bookmark Toolbar URL Bookmark Modal
image image

Speedreader via Toolbar

  • enabled speedreader via brave://flags/#brave-speedreader
  • ensured that clicking on it enabled the feature without any issues
  • visited https://www.theverge.com and selected an article
  • ensured that the article was loaded in reader mode

image

Verification passed on

Brave 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS Ubuntu 18.04 LTS

Bookmarks via Toolbar
image
image

Speedreader via Toolbar
image

@kjozwiak kjozwiak mentioned this issue Jan 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.19.x - Release
Development

Successfully merging a pull request may close this issue.

cr88 followup: Fixes Bookmark & Speed Reader buttons. brave/brave-core
4 participants
@kjozwiak @btlechowski @GeetaSarvadnya @mkarolin