Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR88- Javascript content block is empty in brave://settings/content/javascript #13271

Closed
GeetaSarvadnya opened this issue Dec 21, 2020 · 1 comment · Fixed by brave/brave-core#7571

Comments

@GeetaSarvadnya
Copy link

Description

CR88- Javascript content block is empty in brave://settings/content/javascript

Steps to Reproduce

  1. Clean profile 1.20.x CR 88
  2. Open brave://settings/content/javascript
  3. There are no Add buttons to block and allow sites

Actual result:

image

Expected result:

image

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.20.40 Chromium: 88.0.4315.5 (Official Build) nightly (64-bit)
Revision d2abe4588adaeb0d66aa0a0106675be1dff12c64-refs/branch-heads/4315@{#11}
OS Windows 10 OS Version 2004 (Build 19041.685)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

cc: @brave/legacy_qa @mkarolin @rebron

mkarolin added a commit to brave/brave-core that referenced this issue Jan 12, 2021
Fixes brave/brave-browser#13271

Adjusted a patch to hide only the recommended toggle on the page, but
not the exceptions.
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 12, 2021
@mkarolin mkarolin added this to the 1.20.x - Nightly milestone Jan 13, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jan 14, 2021

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (x86_64)
--- | ---
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | macOS Version 11.1 (Build 20C69)
Default Blocked Allow
Screen Shot 2021-01-13 at 10 10 35 PM Screen Shot 2021-01-13 at 10 10 53 PM Screen Shot 2021-01-13 at 10 12 31 PM

Verification passed on


Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Default Blocked Allow
image image image

Verification passed on

Brave 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
Revision bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS Ubuntu 18.04 LTS
Default Blocked Allow
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants
@kjozwiak @rebron @btlechowski @GeetaSarvadnya @mkarolin and others