remove "{ }" from Ecosia search query

[kjozwiak]

Description

We're currently using https://www.ecosia.org/search?tt=e8eb07a6&q={%s} instead of https://www.ecosia.org/search?tt=e8eb07a6&q=%s which results in search terms appearing in { }. Example: {under armour}.

Steps to Reproduce

1. install 1.19.83 CR: 88.0.4324.79
2. set the default SE to ecosia via brave://settings/search
3. using the omni box, perform a search

Actual result:

Expected result:

Reproduces how often:

100% reproducible when using the STR mentioned above.

Desktop Brave version:

Brave | 1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
-- | --
Revision | bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS | Windows 10 OS Version 2009 (Build 19042.746)

Android Device details:

• Install type (ARM, x86): ARM
• Device type (Phone, Tablet, Phablet): Samsung S10_
• Android version: Android 10

Version/Channel Information:

• Can you reproduce this issue with the current release? No (only 1.19.x and not 1.18.x)
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bsclifton @srirambv @rebron @janypiotrowski

[btlechowski]

Reproduced on Ubuntu

Brave	1.19.83 Chromium: 88.0.4324.79 (Official Build) (64-bit)
Revision	bd1e9353659b2491dac971226a973ca3b5684a14-refs/branch-heads/4324@{#1520}
OS	Ubuntu 18.04 LTS

[srirambv]

Verification passed on Samsung Tab A with Android 10 running 1.19.84 x64 build

• Verified { } isn't added to query string

---

Verification passed on OnePlus 6T with Android 10 running 1.19.84 x64 build

• Verified { } isn't added to query string

---

Verification passed on

Brave | 1.19.84 Chromium: 88.0.4324.87 (Official Build) (64-bit)
-- | --
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | Windows 10 OS Version 2004 (Build 19041.685)

Verified the STR from the description
Ensured that that { } wasn't being used when searching via the Omnibox:

• https://www.ecosia.org/search?tt=e8eb07a6&q=brave+software
• https://www.ecosia.org/search?tt=e8eb07a6&q=bravesoftware

Ensured that that { } wasn't being used when directly searching via the Ecosia:

• https://www.ecosia.org/search?q=BAT+token

Example	Example	Example

Verified upgrading from an older build Ecosia is added to the list of search engines (US locale)
Verified upgrading from older build with Yahoo as default, the setting is retained

---

Verification passed on

Brave	1.19.84 Chromium: 88.0.4324.87 (Official Build) (64-bit)
Revision	dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS	Ubuntu 18.04 LTS

Verified the STR from the description

---

Verified passed with

Brave | 1.19.84 Chromium: 88.0.4324.87 (Official Build) (x86_64)
-- | --
Revision | dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS | macOS Version 10.15.7 (Build 19H15)

Verified STR from description

Confirmed { } removed from search engine URL:

Confirmed searching via omnibox did not add { } to search terms:

Example	Example

Confirmed searching directly on ecosia did not add { } to search terms:

Example	Example