"on YouTube" missing for YT creators on panel, AC list, tips lists

[LaurenWags]

Description

When opening the rewards panel while on a YT creator page, panel should say something like " on YouTube". The "on YouTube" part is missing.

Other creator types "on GitHub", "on Reddit", etc are working as expected.

Reproduces on 1.18.x, 1.19.x, 1.21.x. Maybe related to a Greaselion update?

Steps to Reproduce

1. Clean profile (panel info gets cached and is not currently cleared - see Rewards Panel cached information needs to expire/refresh #6059, so if you visited a page before it will show correctly)
2. Click on panel and join Rewards
3. Navigate to youtube.com/user/jjdsampson
4. Once page loads, open panel

Actual result:

"on YouTube" is missing

If you tip or add to AC list, name will be incorrect here as well.

Expected result:

show "on YouTube" after creator's name

Reproduces how often:

easily

Brave version (brave://version info)

Brave	1.18.78 Chromium: 87.0.4280.141 (Official Build) (x86_64)
Revision	9f05d1d9ee7483a73e9fe91ddcb8274ebcec9d7f-refs/branch-heads/4280@{#2007}
OS	macOS Version 10.15.7 (Build 19H15)

Brave	1.19.84 Chromium: 88.0.4324.87 (Official Build) (x86_64)
Revision	dd01ff8f58c65af81127ad5c105c79d5b571d8f3-refs/branch-heads/4324@{#1702}
OS	macOS Version 10.15.7 (Build 19H15)

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @rebron @emerick @zenparsing @brave/legacy_qa

[emerick]

I believe we need to pass in the media type here:

https://github.com/brave/brave-site-specific-scripts/blob/master/scripts/brave_rewards/publisher/youtube/publisherInfo.ts#L213

[kjozwiak]

Verification PASSED on Win 10 x64 using the following build:

Test Case 1 (New Profile/Logged into KYC/Verified account)

Panel	AC list	Monthly Contribution	Tip

Test Case 2 (New Profile/Not logged into Uphold)

---

Verified passed with

Brave | 1.19.86 Chromium: 88.0.4324.96 (Official Build) (x86_64)
-- | --
Revision | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS Version 10.15.7 (Build 19H15)

Used --use-dev-goupdater-url flag and component version 1.0.44:

Clean profile:

Panel	Auto Contribute	Monthly Contributions	One Time Tips

Upgrade profile:

Issue reproduces on upgrade profile due to #6059

---

erified passed with

Brave	1.19.88 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision	68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS	Linux

Used --use-dev-goupdater-url flag and component version 1.0.44:

Clean profile:

Panel	Auto Contribute	Monthly Contributions	One Time Tips

Upgrade profile:

Issue reproduces on upgrade profile due to #6059

[kjozwiak]

@emerick looks like the above is still occurring if you upgrade from 1.0.41 --> 1.0.44 and you were already in the above state. Example:

@LaurenWags are you seeing the same issue? STR:

• launch 1.19.86 CR: 88.0.4324.96 and log into a KYC/Verified account
• preproduce the original issue and add https://youtube.com/user/jjdsampson into the AC list
• update to 1.0.44 using --use-dev-goupdater-url

[LaurenWags]

@kjozwiak you will still see this issue on upgrade afaik bc the panel info is cached and never expires unfortunately. Issue for that is captured here: #6059

[emerick]

Yep, @LaurenWags is right it's the caching issue.

[kjozwiak]

awesome, thanks @LaurenWags 👍 In that case, the above looks good in Win 10 x64.