You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted in #5720 - if a user has previously attempted to contribute/contributed to a Vimeo publisher - they will have cached the site favicon, instead of the publishers portrait/favicon. This favicon is shown in several places.
We should expire the cache after 30 days generally so we can re-pull other site information as well. This will also fix some previous cases where some incorrect channel information was cached. For safety, we should expire the cache on the next upgrade as well.
Steps to Reproduce
See #5720 for the initial steps - and reproduce using a release build prior to the fix from brave/brave-core#3464
Using the build containing the fix from brave/brave-core#3464, revisit the same publisher and attempt to contribute.
Should Vimeo ever change the portrait ID information we scrape, the issue reported in #5720 would reoccur, and any fix would result in the same 'stale cache' issue noted in this ticket.
As such, we need to ensure these favicons can be updated as and when future changes occur.
The text was updated successfully, but these errors were encountered:
NejcZdovc
added
priority/P3
The next thing for us to work on. It'll ride the trains.
priority/P4
Planned work. We expect to get to it "soon".
and removed
priority/P3
The next thing for us to work on. It'll ride the trains.
labels
Sep 20, 2019
jsecretan
changed the title
Rewards Panel cached favicon needs to expire/refresh
Rewards Panel cached information needs to expire/refresh
Nov 4, 2019
Description
As noted in #5720 - if a user has previously attempted to contribute/contributed to a Vimeo publisher - they will have cached the site favicon, instead of the publishers portrait/favicon. This favicon is shown in several places.
We should expire the cache after 30 days generally so we can re-pull other site information as well. This will also fix some previous cases where some incorrect channel information was cached. For safety, we should expire the cache on the next upgrade as well.
Steps to Reproduce
See #5720 for the initial steps - and reproduce using a release build prior to the fix from brave/brave-core#3464
Using the build containing the fix from brave/brave-core#3464, revisit the same publisher and attempt to contribute.
Actual result:
The site favicon is shown.
Expected result:
The publisher portrait favicon should be shown.
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
This issue will only be evident once brave/brave-core#3464 is released in a build.
Version/Channel Information:
This issue will only be evident once brave/brave-core#3464 is released in a build.
Other Additional Information:
Miscellaneous Information:
Should Vimeo ever change the portrait ID information we scrape, the issue reported in #5720 would reoccur, and any fix would result in the same 'stale cache' issue noted in this ticket.
As such, we need to ensure these favicons can be updated as and when future changes occur.
The text was updated successfully, but these errors were encountered: