Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routinely clear out or expire stale creator info from publisher_info_db so that browser fetches fresh creator info upon next visit #20980

Closed
Miyayes opened this issue Feb 8, 2022 · 5 comments · Fixed by brave/brave-core#13475

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Feb 8, 2022

Description

For example, if a Twitter creator changes their name, and a user had already visited that Twitter account prior to the name change, it will retain the old string and show the old name string in the Rewards panel. The name is essentially cached with no expiration.

Solution

Clear out stale creator entries from publisher_info_db periodically so that the browser fetches new information next time the user visits the creator's page.

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 8, 2022
@Miyayes Miyayes changed the title Routinely clear out or expire stale creator info from publisher_info_db so that browser fetches fresh information Routinely clear out or expire stale creator info from publisher_info_db so that browser fetches fresh creator info upon next visit Feb 8, 2022
@Miyayes Miyayes added the needs-investigation A bug not 100% confirmed/fixed label Feb 9, 2022
@Miyayes Miyayes added priority/P3 The next thing for us to work on. It'll ride the trains. and removed needs-investigation A bug not 100% confirmed/fixed labels Feb 9, 2022
@mkarolin mkarolin added this to the 1.41.x - Nightly milestone May 26, 2022
@mkarolin
Copy link
Contributor

QA steps to verify:

  1. In Brave, navigate to a twitter page you own, e.g. twitter.com/supergood
  2. Open the Rewards panel and note supergood shown in the panel
  3. In twitter settings (account settings) change your name (handle) to something else, e.g. extragood
  4. In Brave, navigate to the page twitter.com/extragood
    Before the fix:
  5. Open the Rewards panel and note supergood is still shown in the panel
    With the fix:
  6. Open the Rewards panel and note extragood is now shown in the panel

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 23, 2022

Verification PASSED on

Brave | 1.41.77 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
-- | --
Revision | a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS | Windows 10 Version 21H2 (Build 19044.1766)

Before the name change After the name change
image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (x86_64)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS macOS Version 11.6.7 (Build 20G630)

Steps:

  1. installed 1.41.82
  2. launched Brave
  3. signed up for a Creators account on staging (creators-staging.brave.com)
  4. linked my Twitch account
  5. connected my Twitch account to my Uphold (sandbox/staging)
  6. confirmed twitch.tv/stephendonner showed up as a Verified Creator in the panel
  7. changed my username to be InitialCaps (only thing allowed by Twitch)
  8. reloaded twitch.tv/stephendonner
  9. waited for a bit
  10. confirmed twitch.tv/stephendonner now has a display name of StephenDonner, as opposed to stephendonner (previously)
example example
Screen Shot 2022-06-29 at 10 31 35 AM Screen Shot 2022-06-29 at 10 35 17 AM

@stephendonner
Copy link

Verified PASSED using Brave

1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (64-bit)
Revision 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS Linux

Confirmed changing display name in Twitch updates it in the Rewards panel

example example
Screen Shot 2022-06-29 at 10 51 54 AM Screen Shot 2022-06-29 at 10 52 37 AM

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 11, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Jul 11, 2022

Verification completed on Samsung Galaxy GS 21 & Tab S7 using

Brave 1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS Android 12; Build/SP1A.210812.016

Using STR in #20980 (comment)

Case 1: Twitter Site
FAIL - Clear out stale creator entries from publisher_info_db periodically so that the browser fetches new information next time the user visits the creator's page.

Encountered: #23994

Example Example
screenshot-1657581034274 screenshot-1657580215942

Case 2: youtube.com / Google

FAIL - Clear out stale creator entries from publisher_info_db periodically so that the browser fetches new information next time the user visits the creator's page.

Created follow up issue for Android - #23995

Example Example Google Profile
screenshot-1657584852892 screenshot-1657584876558 screenshot-1657584465164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment