-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Routinely clear out or expire stale creator info from publisher_info_db
so that browser fetches fresh creator info upon next visit
#20980
Comments
publisher_info_db
so that browser fetches fresh informationpublisher_info_db
so that browser fetches fresh creator info upon next visit
QA steps to verify:
|
Verification PASSED on
|
Verified
|
Brave | 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (x86_64) |
---|---|
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066} |
OS | macOS Version 11.6.7 (Build 20G630) |
Steps:
- installed
1.41.82
- launched Brave
- signed up for a Creators account on staging (
creators-staging.brave.com
) - linked my Twitch account
- connected my Twitch account to my Uphold (
sandbox/staging
) - confirmed twitch.tv/stephendonner showed up as a Verified Creator in the panel
- changed my username to be InitialCaps (only thing allowed by Twitch)
- reloaded twitch.tv/stephendonner
- waited for a bit
- confirmed twitch.tv/stephendonner now has a display name of
StephenDonner
, as opposed tostephendonner
(previously)
example | example |
---|---|
Verified
|
1.41.82 | Chromium: 103.0.5060.66 (Official Build) beta (64-bit) |
---|---|
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066} |
OS | Linux |
Confirmed changing display name in Twitch updates it in the Rewards panel
example | example |
---|---|
Verification completed on Brave 1.41.95 Chromium: 103.0.5060.114 (Official Build) (64-bit) Using STR in #20980 (comment) Case 1: Twitter Site Encountered: #23994
Case 2: youtube.com / Google
Created follow up issue for Android - #23995
|
Description
For example, if a Twitter creator changes their name, and a user had already visited that Twitter account prior to the name change, it will retain the old string and show the old name string in the Rewards panel. The name is essentially cached with no expiration.
Solution
Clear out stale creator entries from
publisher_info_db
periodically so that the browser fetches new information next time the user visits the creator's page.The text was updated successfully, but these errors were encountered: