Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rewards] Update publisher info when name or url change. #13475

Merged
merged 1 commit into from
May 26, 2022

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented May 25, 2022

Fixes brave/brave-browser#20980

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this May 25, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 25, 2022
@mkarolin mkarolin force-pushed the maxk-update-publisher-info branch from cbc5ef2 to e645bbd Compare May 25, 2022 22:16
@mkarolin mkarolin changed the title WIP: [Rewards] Update publisher info when name or url change. [Rewards] Update publisher info when name or url change. May 26, 2022
@mkarolin mkarolin marked this pull request as ready for review May 26, 2022 00:06
@mkarolin mkarolin requested a review from a team as a code owner May 26, 2022 00:06
@mkarolin mkarolin requested review from bsclifton and deeppandya May 26, 2022 00:06
@mkarolin mkarolin force-pushed the maxk-update-publisher-info branch from e645bbd to 94cd8cd Compare May 26, 2022 00:07
@github-actions github-actions bot removed the rebase label May 26, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkarolin mkarolin added this to the 1.41.x - Nightly milestone May 26, 2022
@mkarolin mkarolin merged commit cf82401 into master May 26, 2022
@mkarolin mkarolin deleted the maxk-update-publisher-info branch May 26, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
5 participants