Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joining Rewards via NTP widget does not have onboarding tour opportunity - follow up to 12459 #13912

Closed
LaurenWags opened this issue Feb 2, 2021 · 3 comments
Labels
closed/duplicate Issue has already been reported OS/Desktop

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #12459

Figma doc: https://www.figma.com/file/0dbMYs8Wp8W3RgrG1yTdki/RE-1.0?node-id=2236%3A30931

Per figma design doc for the above issue (look at 1.20. desktop section), when joining Rewards via NTP widget there is no onboarding tour opportunity.

Per the figma doc, when joining via widget the panel should open and show the onboarding tour. This is not occurring.

Steps to Reproduce

  1. Clean profile 1.20.x
  2. Open NTP
  3. Join Rewards via NTP widget

Actual result:

widget state changes, you've joined rewards

Expected result:

Per figma panel should open and show onboarding tour opportunity:
Screen Shot 2021-02-02 at 5 27 36 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.20.96 Chromium: 88.0.4324.96 (Official Build) beta (x86_64)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS macOS Version 10.15.7 (Build 19H15)

Also 1.21.x (Nightly)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes 1.20.x
  • Can you reproduce this issue with the nightly channel? yes 1.21.x

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @brave/legacy_qa @rebron
cc @codybanxs @zenparsing also in case this is expected.

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 22, 2021

@LaurenWags @zenparsing I wonder if this is fixed with the new Rewards NTP widget that came out in v1.33?

@LaurenWags
Copy link
Member Author

@Miyayes no, not fixed with the new NTP widget UI changes from @zenparsing (we discussed when we had the walkthrough).

@rebron
Copy link
Collaborator

rebron commented Mar 22, 2022

closing as dupe of #21811

@rebron rebron closed this as completed Mar 22, 2022
@rebron rebron added closed/duplicate Issue has already been reported and removed feature/rewards priority/P4 Planned work. We expect to get to it "soon". QA/Yes labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Desktop
Projects
None yet
Development

No branches or pull requests

4 participants