Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incognito in upgrade message in Polish locale #14750

Closed
btlechowski opened this issue Mar 15, 2021 · 1 comment · Fixed by brave/brave-core#8306
Closed

Incognito in upgrade message in Polish locale #14750

btlechowski opened this issue Mar 15, 2021 · 1 comment · Fixed by brave/brave-core#8306
Assignees
@mkarolin
Labels
branding l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.22.x - Release

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Run Brave in Polish locale
  2. Open brave://settings/help
  3. Upgrade Brave

Actual result:

Okna incognito
image
image

Expected result:

Prywatne okna

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.21.77 Chromium: 89.0.4389.90 (Official Build) (64-bit)
Revision 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @mkarolin
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Mar 16, 2021
@mkarolin mkarolin mentioned this issue Mar 16, 2021
Merged
24 tasks
mkarolin added a commit to brave/brave-core that referenced this issue Mar 17, 2021
@mkarolin
Fixes brave_strings_override.grd to include a missing grdp override.
b73bae3 
Because brave_strings.grd and settings_brave_strings.grdp are special
cases in terms of naming, the rebase script wasn't adding the GRDP
override to the GRD override.

Addresses brave/brave-browser#14750

Doesn't fix the actual translations, but we should get them the next
time we order.
@mkarolin mkarolin self-assigned this Mar 19, 2021
@mkarolin mkarolin mentioned this issue Mar 19, 2021
Merged
24 tasks
@mkarolin mkarolin added this to the 1.24.x - Nightly milestone Mar 20, 2021
This was referenced Mar 20, 2021
Merged
Merged
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Mar 22, 2021
Closed
@GeetaSarvadnya
Copy link

Verification passed on


Brave | 1.22.66 Chromium: 89.0.4389.90 (Official Build) (64-bit)
-- | --
Revision | 62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS | Windows 10 OS Version 2004 (Build 19041.867)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
branding l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Updated l10n for 1.22.x release (Chromium 89). brave/brave-core
5 participants
@kjozwiak @rebron @btlechowski @GeetaSarvadnya @mkarolin