Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare packaging component crx for background images #14797

Closed
simonhong opened this issue Mar 18, 2021 · 0 comments · Fixed by brave/brave-core-crx-packager#212
Closed

Prepare packaging component crx for background images #14797

simonhong opened this issue Mar 18, 2021 · 0 comments · Fixed by brave/brave-core-crx-packager#212
Assignees
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@simonhong
Copy link
Member

simonhong commented Mar 18, 2021

This is prerequisite for #10278
We're planning to deliver background images via component.

component will have image files and photo.json that describs the infos about included images

crx-packager PR: brave/brave-core-crx-packager#212
jenkins job issue: https://github.com/brave/devops/issues/4680

This is example photo.json.
Same as current NTP bg images list.

{
   "schemaVersion":1,
   "images":[
      {
         "name":"ntp-2020/2021-1",
         "source":"alex-plesovskich.avif",
         "author":"Alex Plesovskich",
         "link":"https://unsplash.com/@aples",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"https://unsplash.com/photos/VPrTqd8B230"
      },
      {
         "name":"ntp-2020/2021-2",
         "source":"andre-benz.avif",
         "author":"Andre Benz",
         "link":"https://unsplash.com/@trapnation",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"https://unsplash.com/photos/axQXVkrUASg"
      },
      {
         "name":"ntp-2020/2021-3",
         "source":"corwin-prescott_olympic.avif",
         "author":"Corwin Prescott",
         "link":"https://community.brave.com/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2020/2021-4",
         "source":"dylan-malval_alps.avif",
         "author":"Dylan Malval",
         "link":"https://www.instagram.com/vass_captures/",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2020/2021-5",
         "source":"sora-sagano.avif",
         "author":"Sora Sogano",
         "link":"https://unsplash.com/@sorasagano",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"https://unsplash.com/photos/UtJcj7_2zRs"
      },
      {
         "name":"ntp-2020/2021-6",
         "source":"spencer-moore_lake.avif",
         "author":"Spencer M. Moore",
         "link":"https://www.smoorevisuals.com/landscapes",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"used with permission"
      },
      {
         "name":"ntp-2020/2021-7",
         "source":"su-san-lee.avif",
         "author":"Su San Lee",
         "link":"https://unsplash.com/@blackodc",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"https://unsplash.com/photos/E_eWwM29wfU"
      },
      {
         "name":"ntp-2020/2021-8",
         "source":"zane-lee.avif",
         "author":"Zane Lee",
         "link":"https://unsplash.com/@zane404",
         "originalUrl":"Contributor sent the hi-res version through email",
         "license":"https://unsplash.com/photos/ZiDa9i7dY1E"
      }
   ]
}
@simonhong simonhong self-assigned this Mar 18, 2021
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 19, 2021
simonhong added a commit to brave/brave-core-crx-packager that referenced this issue Mar 22, 2021
This component delivers background images for NTP.

fix brave/brave-browser#14797
simonhong added a commit to brave/brave-core-crx-packager that referenced this issue Mar 22, 2021
This component delivers background images for NTP.

fix brave/brave-browser#14797
simonhong added a commit to brave/brave-core-crx-packager that referenced this issue Mar 24, 2021
This component delivers background images for NTP.

fix brave/brave-browser#14797
@simonhong simonhong added this to the 1.24.x - Nightly milestone Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants