Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed contribution notification for donations #1481

Closed
NejcZdovc opened this issue Oct 10, 2018 · 4 comments · Fixed by brave/brave-core#890
Closed

Failed contribution notification for donations #1481

NejcZdovc opened this issue Oct 10, 2018 · 4 comments · Fixed by brave/brave-core#890
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

If something goes wrong with donation, user should be notified about that via panel notification.
@NejcZdovc NejcZdovc added this to the 1.0 (0.56.x) milestone Oct 10, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.57.x - Dev Oct 22, 2018
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@NejcZdovc NejcZdovc mentioned this issue Oct 31, 2018
Closed
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, Dupe / Invalid / Not actionable Oct 31, 2018
@NejcZdovc
Copy link
Contributor Author

closing as it will be addressed in this issue #1483

@NejcZdovc NejcZdovc added the closed/duplicate Issue has already been reported label Oct 31, 2018
@NejcZdovc NejcZdovc removed the closed/duplicate Issue has already been reported label Nov 5, 2018
@NejcZdovc NejcZdovc self-assigned this Nov 5, 2018
@NejcZdovc NejcZdovc removed this from the Dupe / Invalid / Not actionable milestone Nov 5, 2018
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 5, 2018
@NejcZdovc NejcZdovc reopened this Nov 5, 2018
@NejcZdovc
Copy link
Contributor Author

blocked on #1483

@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@NejcZdovc NejcZdovc removed this from the 1.x Backlog milestone Nov 13, 2018
@NejcZdovc NejcZdovc added this to the 0.58.x - Dev milestone Nov 13, 2018
@NejcZdovc NejcZdovc removed the blocked label Nov 13, 2018
@NejcZdovc
Copy link
Contributor Author

NejcZdovc commented Nov 13, 2018 •
edited
Loading

done in brave/brave-core#890

@NejcZdovc NejcZdovc mentioned this issue Nov 13, 2018
Merged
18 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.58.x - Dev, 0.57.x - Beta Nov 13, 2018
@LaurenWags LaurenWags mentioned this issue Nov 19, 2018
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Nov 29, 2018 •
edited by btlechowski
Loading

Verified passed with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Mac OS X

Verified PASSED with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Windows

Test plan from brave/brave-core#890

Verified PASSED with

Brave 0.57.8 Chromium: 71.0.3578.53 (Official Build) beta(64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}
OS Linux

Test plan from brave/brave-core#890

@bbondy bbondy changed the title Failed contribution notification Failed contribution notification for donations Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Adds retries into contribution flow for rewards brave/brave-core
5 participants
@bbondy @kjozwiak @NejcZdovc @LaurenWags @btlechowski