Brave Rewards button

[petemill]

Description

A new button in the BraveActions area, along with the Shields button (see #668).
This button should have the following states:

• Rewards On
• Rewards Off
• Non-Rewards page

Clicking the button should invoke a web-ui popup which displays overall Rewards status (balance, etc) and actions for the active Tab. TBD whether this is an extension page or webui page.

[NejcZdovc]

There is one more stage, rewards on with notification

[petemill]

Here's my current thoughts on how we should do the data for this button:

• Create a browser class very similar to ExtensionAction, RewardsAction. This can have per-tab data for icon and badge text, falling back to global values if no per-tab value is set. It will be the central class for the Rewards service to update the icon data (based on the navigation events it needs to monitor), and the UI layer to read the data from. It will store:
  • Which icon state to be in, per-tab. We can use an enum value instead of an exact Image here.
  • Badge text

As already decided, clicking the button will open a WebUI page in a popup. If we need to vary the exact URL that should open based on the tab publisher state or otherwise (which I don't think we will want to do atm) then RewardsAction can also store the URL which should open.

Since you've been working on the Rewards service so far and and I haven't looked at the branch yet @bridiver @NejcZdovc please let me know if you think this is something the Rewards service can send the data to for each tab.

[NejcZdovc]

@petemill update. We will only have enable and disable state. There will not be verified state

[bridiver]

I think this probably makes more sense as an extension browser/page action. Then there's no need for a bunch of new code to handle opening a webui page

[bridiver]

we can create a new extension api to provide the necessary info

[NejcZdovc]

@petemill url will always be the same (that we want to open). webui will receive publisher data that will be displayed. It will also receive wallet summary for the current month

[bridiver]

actually we should look at component actions too and possibly subclass ExtensionActionViewController for it

[petemill]

Sure @bridiver we can probably use another extension - I believe in a previous discussion @bbondy may have mentioned WebUI was preferable. I forget the reasons, but possibly due to ease of specific data access and providing events, though obviously we do that for shields.

I have already subclassed ExtensionActionViewController for the shields button in order to give it a different style to the other extensions.

[bridiver]

I think creating a popup view that displays a webui is probably going to be more complicated, but we can potentially subclass ExtensionActionViewController to do that as well

[petemill]

@bridiver I did a cursory look and the popup accepts a GURL pretty early on in the call stack

[bridiver]

you can't just pass any url to it. It creates an extension host and you can't open a webui in an extension process. Even if it allows you to which I don't think it will, you would be creating a security issue

[NejcZdovc]

update: we will just have on state and notification indicator if there will be one

[NejcZdovc]