Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Sadly, no tokens yet" after importing wallet with non-zero balance #2260

Closed
garrettr opened this issue Nov 27, 2018 · 4 comments · Fixed by brave/brave-core#1004
Closed

Comments

@garrettr
Copy link
Contributor

garrettr commented Nov 27, 2018

Description

After importing a funded Brave Payments wallet into Brave Rewards, the Rewards Settings page shows the correct non-zero balance for the wallet, but continues to show the "Sadly, no tokens yet" sidebar. This is confusing because it contradicts the existence of the tokens from the imported wallet, which are reflected in the displayed non-zero wallet balance.

Test plan / Steps to Reproduce

  1. Import Muon/Brave Payments wallet into b-c/Brave Rewards (detailed test plan in Import Brave Payments data from Muon brave-core#736).
  2. Click Brave Rewards icon in address bar, then Rewards Settings in the dropdown.

Actual result:

screen shot 2018-11-27 at 2 24 57 pm

Expected result:

If the wallet balance is zero, the sidebar should not say "no tokens yet."

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.59.1 Chromium: 71.0.3578.53 (Developer Build) (64-bit)
Revision 599fb72e740eab9d10609f1ed28a2ad669f82c1a-refs/branch-heads/3578@{#669}

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes
@LaurenWags
Copy link
Member

LaurenWags commented Dec 5, 2018

Still experiencing this with

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

screen shot 2018-12-05 at 6 02 54 pm

cc @bsclifton @rebron @kjozwiak

@btlechowski
Copy link

Also reproducible on Windows:

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows 7

@LaurenWags
Copy link
Member

Using the below build

Brave 0.57.17 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Found that issue was not fixed, logged follow up issue #2379

@GeetaSarvadnya
Copy link

Verified the issue using the below build

Brave 0.57.18 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment