Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Shields extension button to URL bar #668

Closed
petemill opened this issue Jul 31, 2018 · 1 comment
Closed

Move Shields extension button to URL bar #668

petemill opened this issue Jul 31, 2018 · 1 comment
Assignees
@petemill
Labels
design A design change, especially one which needs input from the design team QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

petemill commented Jul 31, 2018 •
edited
Loading

Description

Move from BrowserActions area to PageActions area.
Clicking should still invoke the extension popup.
Button should have the following states:

  • Shields on (with notification count)
  • Shields off
  • Non-shield compatible page

image
@petemill petemill added the design A design change, especially one which needs input from the design team label Jul 31, 2018
@petemill petemill self-assigned this Jul 31, 2018
@petemill petemill mentioned this issue Jul 31, 2018
Closed
@petemill petemill added this to the Releasable builds milestone Jul 31, 2018
@bbondy bbondy mentioned this issue Aug 18, 2018
Closed
@petemill petemill mentioned this issue Aug 20, 2018
Merged
9 tasks
@petemill petemill mentioned this issue Aug 26, 2018
Merged
petemill added a commit to petemill/brave-extension that referenced this issue Aug 27, 2018
@petemill
Initialize the Browser Action and set some settings:
b2511ea 
- Badge color
- Higher resolution (vector) icon
  (Fix brave/brave-browser#844)
- Badge displays '99+' when block count is > 99
- Shields are disabled for non-http(s) sites
  (Fix brave/brave-browser#503)
- Default icon before a tab loads is the shields-on icon
- Set shields badge count for active tab only
  (Fix brave/brave-browser#743)

Address some features of brave/brave-browser#668
petemill added a commit to petemill/brave-core that referenced this issue Aug 30, 2018
@petemill
Create BraveActionsContainer and add Shields extension button to it.
f352ef9 
Fix brave/brave-browser#668
Intention is for Shields 'extension' to feel built-in.
BraveActionsContainer hooks in to extension system in order to display and update the button icon when necessary.
Displays a custom badge which is sized and positioned specifically for the Shields count. Uses dynamic font sizing to maintain a target height and maximum width.
Removes the Shields extension button from main extensions area (ToolbarActionsBar / BrowserActionsContainer).
Disable context menu for shields extension button in brave actions area since there are no valid actions.
Patches the content of a method at LocationBarView::Layout since it could be more harmful to copy that functionality to our subclass because it is complex and somewhat functional logic. Attempts to minimize the patching necessary by passing in a new argument to the method.
@bbondy bbondy added the QA/Yes label Sep 10, 2018
@mkarolin mkarolin mentioned this issue Sep 11, 2018
Merged
11 tasks
@srirambv
Copy link
Contributor

srirambv commented Sep 25, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
-- image
-- image
-- image

Verification PASSED on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
design A design change, especially one which needs input from the design team QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
5 participants
@petemill @bbondy @srirambv @LaurenWags @GeetaSarvadnya