Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields icon is pixelated #844

Closed
petemill opened this issue Aug 26, 2018 · 1 comment
Closed

Shields icon is pixelated #844

petemill opened this issue Aug 26, 2018 · 1 comment
Assignees
@petemill
Labels
design A design change, especially one which needs input from the design team QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@petemill
Copy link
Member

image
@petemill petemill added the design A design change, especially one which needs input from the design team label Aug 26, 2018
@petemill petemill added this to the Releasable builds 0.55.x milestone Aug 26, 2018
@petemill petemill self-assigned this Aug 26, 2018
@petemill petemill mentioned this issue Aug 26, 2018
Merged
petemill added a commit to petemill/brave-extension that referenced this issue Aug 27, 2018
@petemill
Initialize the Browser Action and set some settings:
b2511ea 
- Badge color
- Higher resolution (vector) icon
  (Fix brave/brave-browser#844)
- Badge displays '99+' when block count is > 99
- Shields are disabled for non-http(s) sites
  (Fix brave/brave-browser#503)
- Default icon before a tab loads is the shields-on icon
- Set shields badge count for active tab only
  (Fix brave/brave-browser#743)

Address some features of brave/brave-browser#668
@srirambv srirambv added the QA/Yes label Sep 9, 2018
@kjozwiak
Copy link
Member

kjozwiak commented Sep 21, 2018 •
edited by srirambv
Loading

Went through verification using the following build under macOS 10.13.6 x64 - PASSED

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
design A design change, especially one which needs input from the design team QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
5 participants
@petemill @bbondy @kjozwiak @srirambv @btlechowski