Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields should not be clickable on about pages (Follow up to #169) #503

Closed
srirambv opened this issue Jul 7, 2018 · 2 comments
Closed

Shields should not be clickable on about pages (Follow up to #169) #503

srirambv opened this issue Jul 7, 2018 · 2 comments
Assignees
@petemill
Labels
browser-laptop-parity feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 7, 2018

Description

Shields should not be clickable on about pages (Follow up to #169)

Steps to Reproduce

  1. Install build
  2. Open settings page
  3. Shields looks disabled but still clickable

Actual result:

Shields should not be clickable on about pages

Expected result:

Should not be clickable. Should have same behaviour as browser-laptop

Reproduces how often:

100%

Brave version (about:brave info)

Packaged build

Reproducible on current release:

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

#169
@srirambv srirambv added feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. browser-laptop-parity labels Jul 7, 2018
@srirambv srirambv added this to the Backlog milestone Jul 7, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Jul 7, 2018

Not sure how it is possible since shields is an extension and all extensions are clickable and opens extension page on about pages as well.

@srirambv srirambv removed this from the Backlog milestone Jul 7, 2018
@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@petemill petemill assigned petemill and unassigned cezaraugusto Aug 26, 2018
@petemill petemill mentioned this issue Aug 26, 2018
Merged
petemill added a commit to petemill/brave-extension that referenced this issue Aug 27, 2018
@petemill
Initialize the Browser Action and set some settings:
b2511ea 
- Badge color
- Higher resolution (vector) icon
  (Fix brave/brave-browser#844)
- Badge displays '99+' when block count is > 99
- Shields are disabled for non-http(s) sites
  (Fix brave/brave-browser#503)
- Default icon before a tab loads is the shields-on icon
- Set shields badge count for active tab only
  (Fix brave/brave-browser#743)

Address some features of brave/brave-browser#668
@srirambv srirambv added the QA/Yes label Sep 9, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 21, 2018 •
edited by LaurenWags
Loading

Verification PASS on:

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
browser-laptop-parity feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
6 participants
@petemill @bbondy @cezaraugusto @srirambv @LaurenWags @GeetaSarvadnya