This repository has been archived by the owner on Jun 6, 2019. It is now read-only.
Initialize the Browser Action and set some settings #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
petemill
force-pushed
the
browser-action-settings
branch
from
64a8c88
to
21d8bd9
Compare
- Badge color - Higher resolution (vector) icon (Fix brave/brave-browser#844) - Badge displays '99+' when block count is > 99 - Shields are disabled for non-http(s) sites (Fix brave/brave-browser#503) - Default icon before a tab loads is the shields-on icon - Set shields badge count for active tab only (Fix brave/brave-browser#743) Address some features of brave/brave-browser#668
petemill
force-pushed
the
browser-action-settings
branch
from
eb9bb8a
to
b2511ea
Compare
cezaraugusto
approved these changes
Aug 28, 2018
| @@ -13,72 +13,71 @@ describe('BrowserAction API', () => { | |||
| before(function () { | |||
| this.spy = sinon.spy(chrome.browserAction, 'setBadgeText') | |||
| this.text = '42' | |||
| browserActionAPI.setBadgeText(this.text) | |||
| this.tabId = 1337 | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#844
Fix brave/brave-browser#503
Address brave/brave-browser#668
Shields on
Shields off
Shields disabled (webui page)
