Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields should be disabled for about pages #169

Closed
jumde opened this issue Apr 24, 2018 · 2 comments · Fixed by brave/brave-extension#45
Closed

Shields should be disabled for about pages #169

jumde opened this issue Apr 24, 2018 · 2 comments · Fixed by brave/brave-extension#45
Assignees
@cezaraugusto
Labels
bug feature/brave-pages feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Apr 24, 2018

screen shot 2018-04-24 at 4 27 18 pm
@cezaraugusto cezaraugusto mentioned this issue May 30, 2018
Closed
@cezaraugusto cezaraugusto added bug feature/brave-pages feature/shields The overall Shields feature in Brave. labels May 30, 2018
@cezaraugusto cezaraugusto self-assigned this May 30, 2018
@bbondy bbondy added this to the Milestone 3: June-July milestone Jun 6, 2018
@srirambv
Copy link
Contributor

Changing drop down or clicking on the switch reloads the page but setting doesn't change
pagereload

@cezaraugusto cezaraugusto mentioned this issue Jun 25, 2018
Merged
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 3, 2018
@cezaraugusto
disable shields for any protocol other than http or https
e21abf2 
-
fix brave/brave-browser#169
@cezaraugusto cezaraugusto mentioned this issue Jul 3, 2018
Merged
cezaraugusto added a commit to brave/brave-extension that referenced this issue Jul 4, 2018
@cezaraugusto
disable shields for any protocol other than http or https
e5dabe1 
-
fix brave/brave-browser#169
@srirambv srirambv mentioned this issue Jul 7, 2018
Closed
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@btlechowski
Copy link

btlechowski commented Sep 21, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Checked all links from chrome:about

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added the QA/Yes label Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/brave-pages feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

disable shields for any protocol other than http or https brave/brave-extension
6 participants
@bbondy @jumde @cezaraugusto @srirambv @LaurenWags @btlechowski