You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you change your system language to French or some other language, localization will not show up on web-ui pages.
Steps to Reproduce
Change source language on macOS in system preferences (other OS instructions may differ)
Launch Brave with a fresh profile
Navigate to brave://rewards
Actual result:
In step 2. on the welcome page you'll see no translated strings.
In step 3. you'll also see no translated strings.
Expected result:
Translated strings should show up (note that maybe not all of them will actually show up if we are missing translations, but at least some of them should show up to resolve this issue).
Reproduces how often:
Always.
Brave version (brave://version info)
All but I'm using 0.57.4
Reproducible on current release:
Does it reproduce on brave-browser dev/beta builds?
Yes.
Website problems only:
Does the issue resolve itself when disabling Brave Shields? No.
Is the issue reproducible on the latest version of Chrome? No, Chrome translates its web-ui pages. But it doesn't have the ones in question. We do translate the Chrome ones correctly.
Additional Information
The text was updated successfully, but these errors were encountered:
bbondy
changed the title
Localization doesn't work in web-ui pages like brave://welcome and brave://rewards
Localization doesn't work in for Brave chrome strings and web-ui pages like brave://welcome and brave://rewards
Nov 7, 2018
bbondy
added a commit
to brave/brave-core
that referenced
this issue
Nov 7, 2018
Description
If you change your system language to French or some other language, localization will not show up on web-ui pages.
Steps to Reproduce
Actual result:
In step 2. on the welcome page you'll see no translated strings.
In step 3. you'll also see no translated strings.
Expected result:
Translated strings should show up (note that maybe not all of them will actually show up if we are missing translations, but at least some of them should show up to resolve this issue).
Reproduces how often:
Always.
Brave version (brave://version info)
All but I'm using 0.57.4
Reproducible on current release:
Yes.
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: